Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup a "plan" presubmit #54

Open
mattmoor opened this issue Jan 25, 2024 · 1 comment · Fixed by #197 · May be fixed by #286
Open

Setup a "plan" presubmit #54

mattmoor opened this issue Jan 25, 2024 · 1 comment · Fixed by #197 · May be fixed by #286
Assignees
@cpanato

Comments

@mattmoor
Copy link
Collaborator

This needs two separate PRS.

  1. We should create a NEW identity in iac/bootstrap that's a project viewer and can be federated by pull requests presubmit (e.g. ref:refs/heads/main -> :pull_request). -- I may need to apply this once it lands, or add folks to ACLs.

  2. We should add a presubmit like mono that posts the plan to the PR body.

cc @cpanato
@cpanato cpanato self-assigned this Feb 6, 2024
@cpanato cpanato mentioned this issue Feb 6, 2024
Merged
mattmoor added a commit that referenced this issue Feb 8, 2024
@cpanato @mattmoor
add new identity to run terraform plan on PRs (#97)
51964c8 
Not sure how to define the `pull-request` in the new identity 

Related to #54

---------

Signed-off-by: Carlos Tadeu Panato Junior <[email protected]>
Co-authored-by: Matt Moore <[email protected]>
@cpanato cpanato self-assigned this Mar 14, 2024
@cpanato cpanato mentioned this issue Mar 28, 2024
Merged
mattmoor pushed a commit that referenced this issue May 17, 2024
@cpanato
add verify prod and refactor terraform check/deploy (#197)
8de4604 
Fixes #54

Need #196
@mattmoor mattmoor reopened this May 17, 2024
@mattmoor
Copy link
Collaborator Author

This failed

@cpanato cpanato linked a pull request May 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpanato cpanato

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mattmoor @cpanato