Merge pull request #42 from octabytes/feature

bug fix in text field format

Author: AxeemHaider

setup.py

@@ -16,7 +16,7 @@
     # Versions should comply with PEP440.  For a discussion on single-sourcing
     # the version across setup.py and the project code, see
     # https://packaging.python.org/en/latest/single_source_version.html
-    version='1.2.1',
+    version='1.2.2',
 
     description="FireO ORM is specifically designed for the Google's Firestore",
     long_description=long_description,

src/fireo/fields/text_field.py

@@ -60,6 +60,12 @@ def db_value(self, val):
 
     # override method
     def field_value(self, val):
+
+        # check if val is None then there is no need to run these functions
+        # just return back the None value
+        if val is None:
+            return val
+
         self.field_attribute.parse(val, run_only=['format'])
         if self.format_type:
             if self.format_type in self.supported_types:

…c/tests/v121/test_lowercase_with_none.py src/tests/v12/test_lowercase_with_none.pysrc/tests/v121/test_lowercase_with_none.py renamed to src/tests/v12/test_lowercase_with_none.py src/tests/v121/test_lowercase_with_none.py renamed to src/tests/v12/test_lowercase_with_none.py

@@ -0,0 +1,17 @@
+from fireo.fields import TextField
+from fireo.models import Model
+
+
+def test_format_with_none_value():
+    class TextFieldFormatNone(Model):
+        name = TextField()
+        address = TextField(format='upper')
+
+    t = TextFieldFormatNone()
+    t.name = 'name'
+    t.save()
+
+    tf = TextFieldFormatNone.collection.get(t.key)\
+
+    assert tf.name == 'name'
+    assert tf.address is None