Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema for historical officers #3

Open
dkess opened this issue Jan 13, 2019 · 2 comments
Open

Schema for historical officers #3

dkess opened this issue Jan 13, 2019 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@dkess
Copy link
Member

dkess commented Jan 13, 2019

See ocf.io/d/85. This would be used on our officers page and would be the new canonical source of "who is gm/sm currently"

@jyxzhang
Copy link
Contributor

This is my first time working with schemas, so hopefully everything is working out. This is my first draft of a historical officers schema. 0f7ee3f It should be a list of terms, with each term having a list of officers. Currently, each term has just one array of officers in general, but I am wondering whether it would be better to have a list of GMs, a list of SMs, (and then optional lists of DGMs, DSMs, committee heads). With that approach, if there are further changes to officer structure, this schema would have to be updated as well (but that probably isn't too much work...).
The .yaml and everything else is not done yet.
What are your thoughts?

@dkess
Copy link
Member Author

dkess commented Jun 14, 2021

Don't be afraid to make a proper PR and list me as a reviewer! It doesn't have to be perfect at all, but it makes it easier to have a comment/revision cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants