Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't have a module called "React" and run dune utop #10656

Closed
davesnx opened this issue Jun 19, 2024 · 4 comments
Closed

Can't have a module called "React" and run dune utop #10656

davesnx opened this issue Jun 19, 2024 · 4 comments

Comments

@davesnx
Copy link
Contributor

davesnx commented Jun 19, 2024

Expected Behavior

Load utop with a file called React

Actual Behavior

→ ~/C/g/m/server-reason-react on main ✓ dune utop
File "_none_", line 1:
Error: Files packages/react/src/react.cma(React)
       and foo/server-reason-react/_opam/lib/react/react.cma(React)
       both define a module named React

Reproduction

git clone https://github.com/ml-in-barcelona/server-reason-react
make init
dune utop

Related issue: ml-in-barcelona/server-reason-react#38

Forgot that there's a PR already open about this #8735

@nojb
Copy link
Collaborator

nojb commented Jun 19, 2024

I don't think there is much Dune can do here; utop already links to React, so you cannot link it again to it...

@davesnx
Copy link
Contributor Author

davesnx commented Jun 19, 2024

What about vendor React and Lwt inside dune and prefix them?

@nojb
Copy link
Collaborator

nojb commented Jun 19, 2024

What about vendor React and Lwt inside dune and prefix them?

This strikes me as something that should rather be suggested to the utop maintainers, do you agree?

@davesnx
Copy link
Contributor Author

davesnx commented Jun 19, 2024

Yes, that falls into utop. I will reopen the issue there: ocaml-community/utop#463

@davesnx davesnx closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants