-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSCore backend doesn't look C89 clean #29
Comments
You are right... I was not careful here. |
Fix clang warning due to SWIG_AddCast macro (SF#1300).
@ewmailing Do u consider this done or should we keep this open? |
Keep this open for now unless you there was a serious push to clean I'm still transitioning to the latest tip. The rebase that happened I'm finally moving things over to the latest (and hoping there will be But a month ago, I was on Windows/Visual Studio, and remember hitting Also, a quick note, I'm currently not doing any v8 stuff, so I don't |
I've been visually looking at the JSCore output. I don't think it is C89 clean.
For example, I see the use of "bool" as a type which is not standard in C89.
And I'm seeing some places where variables are not declared at the top of the scope. (I think SWIG_JSC_NewPointerObj is an example of this.)
This will be a problem for the antiquated Visual Studio C compiler.
The text was updated successfully, but these errors were encountered: