Skip to content

Commit c16669c

Browse files
committed
Request: Minor code cleanup
1 parent 0269209 commit c16669c

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/requesthandler/rpc/Request.cpp

+2-3
Original file line numberDiff line numberDiff line change
@@ -143,28 +143,27 @@ obs_source_t *Request::ValidateScene(const std::string keyName, RequestStatus::R
143143

144144
std::string sceneName = RequestData[keyName];
145145

146-
obs_source_t *ret = obs_get_source_by_name(sceneName.c_str());
146+
OBSSourceAutoRelease ret = obs_get_source_by_name(sceneName.c_str());
147147
if (!ret) {
148148
statusCode = RequestStatus::ResourceNotFound;
149149
comment = std::string("No scene was found by the name of `") + sceneName + "`.";
150150
return nullptr;
151151
}
152152

153153
if (obs_source_get_type(ret) != OBS_SOURCE_TYPE_SCENE) {
154-
obs_source_release(ret);
155154
statusCode = RequestStatus::InvalidResourceType;
156155
comment = "The specified source is not a scene.";
157156
return nullptr;
158157
}
159158

160159
OBSScene scene = obs_scene_from_source(ret);
161160
if (obs_scene_is_group(scene)) {
162-
obs_source_release(ret);
163161
statusCode = RequestStatus::InvalidResourceType;
164162
comment = "The specified source is not a scene.";
165163
return nullptr;
166164
}
167165

166+
obs_source_addref(ret);
168167
return ret;
169168
}
170169

0 commit comments

Comments
 (0)