-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download numbers for plugins are inflated #565
Comments
Wow - thank you very much indeed for logging this. |
So I think you are specifically talking about plugin download numbers as opposed to theme ones, so I'll edit the title. |
Yeah, theme download count's looks correct. |
The theme download counts are obtained by a script which reads the theme downloads from the obsidian-releases vault. This issue made me wonder whether we should get the plugin downloads from the same location. |
I just noticed thanks to this: https://discord.com/channels/686053708261228577/694233507500916796/1050499532326187038 that the plugin download numbers in the hub are quite inflated.
This is because the service used to get the badges sums up downloads for all files, from all releases.
The official script only counts downloads for the
manifest.json
, since Obsidian downloads these files automatically:manifest.json
main.js
styles.css
(if existing)Depending on if
styles.css
exits your numbers are inflated by 2 or 3 times.The text was updated successfully, but these errors were encountered: