Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download numbers for plugins are inflated #565

Open
joethei opened this issue Dec 8, 2022 · 5 comments
Open

Download numbers for plugins are inflated #565

joethei opened this issue Dec 8, 2022 · 5 comments

Comments

@joethei
Copy link
Member

joethei commented Dec 8, 2022

I just noticed thanks to this: https://discord.com/channels/686053708261228577/694233507500916796/1050499532326187038 that the plugin download numbers in the hub are quite inflated.

This is because the service used to get the badges sums up downloads for all files, from all releases.

The official script only counts downloads for the manifest.json, since Obsidian downloads these files automatically:

  • manifest.json
  • main.js
  • styles.css (if existing)

Depending on if styles.css exits your numbers are inflated by 2 or 3 times.

@claremacrae
Copy link
Contributor

Wow - thank you very much indeed for logging this.

@claremacrae
Copy link
Contributor

So I think you are specifically talking about plugin download numbers as opposed to theme ones, so I'll edit the title.

@claremacrae claremacrae changed the title Download numbers are inflated Download numbers for plugins are inflated Dec 8, 2022
@joethei
Copy link
Member Author

joethei commented Dec 8, 2022

Yeah, theme download count's looks correct.

@claremacrae
Copy link
Contributor

The theme download counts are obtained by a script which reads the theme downloads from the obsidian-releases vault.

This issue made me wonder whether we should get the plugin downloads from the same location.
The script will typically run once a week, so it won't hammer GitHub.

@4Source
Copy link

4Source commented Mar 2, 2024

This could use an other badge style also not perfect but matches the download count of the plugin.

![GitHub Downloads (specific asset, all releases)](https://img.shields.io/github/downloads/4Source/settings-profiles-obsidian-plugin/main.js?style=for-the-badge&logo=github&color=573E7A)

GitHub Downloads (specific asset, all releases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants