Change Websocket client to Jetty 11.0.13 #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopheCVB
requested changes
Jan 3, 2023
|
Running them local worked without an issue due to me compiling it with Java 17. The CI/CD Pipeline seems to only accept Java 8 code though. |
|
That update will have to wait then, this library is meant to suport Java 8. Maybe for the v3? |
|
I would recommend explicitly stating that this library is meant to support Java 8 in the README.md of the project then, to avoid future problems like this. Idk what's the correct handling of this PR is now, if it's not going into v2. |
|
Let's get back to this when we work on v3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Jetty Websocket requires minimal changes and does not break any tests.
Closes #162