Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure marks are not shown on Flipper timeline #104

Open
Eljoy opened this issue Feb 7, 2024 · 0 comments
Open

Measure marks are not shown on Flipper timeline #104

Eljoy opened this issue Feb 7, 2024 · 0 comments

Comments

@Eljoy
Copy link

Eljoy commented Feb 7, 2024

Operating System: iOS 
Device: iOS simulator 
"react-native": "0.70.6"
"react-native-performance": "^5.1.0"
"react-native-performance-flipper-reporter": "^5.0.0",
Flipper Version: 0.239.0

While logging for custom measure events works:

  React.useEffect(() => {
    new PerformanceObserver((list) => {
      const entries = list.getEntries()
      console.log(entries)
    }).observe({ entryTypes: ['mark', 'measure'] })
})

  useEffect(() => {
    performance.mark('customEventStart')
    setTimeout(() => {
      performance.mark('customEventEnd')
      performance.measure(
        'customEventDuration',
        'customEventStart',
        'customEventEnd'
      )
    }, 3000)
  }, [])

this data is not being propagated to Flipper Performance plugin timeline.

The timeline only shows bundleSize and nativeLaunch data.

Does it require additional customization aside from

require('react-native-performance-flipper-reporter').setupDefaultFlipperReporter()

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant