Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some .md are missing and we don't check this #55

Closed
yegor256 opened this issue Nov 28, 2024 · 4 comments · Fixed by #326
Closed

some .md are missing and we don't check this #55

yegor256 opened this issue Nov 28, 2024 · 4 comments · Fixed by #326
Assignees
@h1alexbel
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@yegor256
Copy link
Member

Currently, not every .xsl lint has a matching .md file. However, the build passes. I suggest we create an additional unit test that would verify that every .xsl from our collection of lints do have a Markdown motive.
@yegor256 yegor256 added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Nov 28, 2024
@h1alexbel
Copy link
Contributor

@yegor256 assign me, please

@yegor256
Copy link
Member Author

@h1alexbel you already have 4 tasks assigned. Maybe it's better to fix those already assigned and then take more. This will help us not block too many tasks, preventing other contributors from taking them. WDYT?

@h1alexbel
Copy link
Contributor

@yegor256 good, also though about this.

@h1alexbel
Copy link
Contributor

@yegor256 I'm in

h1alexbel added a commit to h1alexbel/lints that referenced this issue Feb 11, 2025
@h1alexbel
feat(objectionary#55): test
9bab6fb
h1alexbel added a commit to h1alexbel/lints that referenced this issue Feb 11, 2025
@h1alexbel
feat(objectionary#55): missing motives
d500360
@h1alexbel h1alexbel mentioned this issue Feb 11, 2025
Merged
yegor256 added a commit that referenced this issue Feb 12, 2025
@yegor256
Merge pull request #326 from h1alexbel/55
5f87824 
feat(#55): check motives for presence in `LtByXslTest`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h1alexbel h1alexbel

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#55): check motives for presence in LtByXslTest h1alexbel/lints
2 participants
@yegor256 @h1alexbel