Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Keys in FolderViewController Causing Wrong Animations #7

Open
brynbodayle opened this issue Jul 26, 2018 · 1 comment
Open

Incorrect Keys in FolderViewController Causing Wrong Animations #7

brynbodayle opened this issue Jul 26, 2018 · 1 comment

Comments

@brynbodayle
Copy link

These keys in FolderViewController are reversed and cause some changes to call reloadData instead of the correct insert animation. This incorrect code is in the book as well.

let oldValue = userInfo[Item.newValueKey]
let newValue = userInfo[Item.oldValueKey]

https://github.com/objcio/app-architecture/blob/master/Recordings-MVC/Recordings/FolderViewController.swift#L42-L43
@OmranK
Copy link

OmranK commented Jan 13, 2020

Confirmed, switch the values to make animation work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brynbodayle @OmranK