Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can there be an easier way to get a full version of the code? #12

Open
kgaidis opened this issue Oct 27, 2018 · 4 comments
Open

Can there be an easier way to get a full version of the code? #12

kgaidis opened this issue Oct 27, 2018 · 4 comments

Comments

@kgaidis
Copy link

kgaidis commented Oct 27, 2018

Hello,

I bought the book. I clicked the download link, pressed the .epub and it opened in Books. 👍

I bought the videos. I clicked the download link, pressed the .m4v and it opened in Quicktime Player. 👍

I cloned this repository. I clicked on the Xcode project and got build errors. And then it started a chain nightmare of updating Carthage, fixing brew, fixing macOS permissions, reading about how Carthage maybe only builds for latest Swift version (4.2) while RxSwift.framework is built for 4.0.2 through git issues etc. etc.

Can the dependencies be uploaded, or can there be a step-by-step guide where I can 100% make sure that the project builds? I feel like the code is part of the "product" and it's sad that everyone who clones it has to potentially go through hours of re-configuration. Some of this maybe will be unavoidable (ex. getting an older version of Xcode), but at least that's the only step I would have to take.

(P.S. The particular project that I mentioned is MVVM-C)

@chh51
Copy link

chh51 commented Oct 27, 2018 via email

@kgaidis
Copy link
Author

kgaidis commented Oct 27, 2018

@chh51

I understand, and agree, that it's not easy to update these types of things and that constant changes do not make it easy to maintain. I would side with the opinion that eventually this would be too much to ask for.

I do feel like this process can be made easier, at least for a little bit of time. For example, I think if I download Xcode 9, and the dependencies are also uploaded/checked-in to the git repository, I think I will be able to run the project. Could be wrong, but this feels like an easy fix: provide some help to download Xcode 9 in the README, and upload dependencies. Or even if I can't get it to build, I can maybe browse some of the source code from the dependencies to get a better picture. In fact, the origin for wanting to get the dependencies was to read docs for flatMapLatest 😁

@NielsNorskov
Copy link

To anyone having issues getting the carthage build to work, I got the carthage build (for MVVM-C) working for the newest XCode (10.1) by editing the cartfile as follows:

github "ReactiveX/RxSwift" "4.3.1"    
github "RxSwiftCommunity/RxDataSources" "3.1.0"

@frye3k
Copy link

frye3k commented Dec 14, 2018

The above worked for me! Thanks @NielsNorskov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants