Newtonsoft.Json.Linq.JObject is not serialized/deserialized correctly

[branimirangelov]

Send large object before the previous is handled by the listening stream leads to stalling.

[branimirangelov]

@VikVelev - could you please comment when you have the code committed

[bojidar-bg]

Debugged the issue using the sample code, it was reproducible under both 0.4.x and 0.5.1.
It turned out to be a problem while deserializing an element of a Newtonsoft.Json.Linq.JArray, likely a Newtonsoft.Json.Linq.JObject. From there, it seems like Ignite tried to deserialize JPropertyKeyedCollection.Comparer, a private readonly static property.

Sample stack trace:

System.Runtime.Serialization.SerializationException: The constructor to deserialize an object of type 'System.OrdinalCaseSensitiveComparer' was not found.                                                                                                                                                    
   at Apache.Ignite.Core.Impl.Common.SerializableTypeDescriptor.get_SerializationCtorUninitialized()
   at Apache.Ignite.Core.Impl.Binary.SerializableSerializer.ReadBinary[T](BinaryReader reader, IBinaryTypeDescriptor desc, Int32 
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.ReadFullObject[T](Int32 pos, Type typeOverride)
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.TryDeserialize[T](T& res, Type typeOverride)
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.Deserialize[T](Type typeOverride)
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.ReadObject[T](String fieldName)
   at Apache.Ignite.Core.Impl.Binary.SerializableSerializer.ReadSerializationInfo(BinaryReader reader, IEnumerable`1 fieldNames, Type type, ICollection`1 dotNetFields)                                                                                                                                                                                         
   at Apache.Ignite.Core.Impl.Binary.SerializableSerializer.ReadBinary[T](BinaryReader reader, IBinaryTypeDescriptor desc, Int32 pos, Type typeOverride)
[.. recursive ..]
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.ReadFullObject[T](Int32 pos, Type typeOverride)
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.TryDeserialize[T](T& res, Type typeOverride)
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.Deserialize[T](Type typeOverride)
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.ReadObject[T](String fieldName)
   at lambda_method(Closure , Object , IBinaryReader )
   at Apache.Ignite.Core.Impl.Binary.BinaryReflectiveSerializerInternal.Apache.Ignite.Core.Impl.Binary.IBinarySerializerInternal.ReadBinary[T](BinaryReader reader, IBinaryTypeDescriptor desc, Int32 pos, Type typeOverride)
[.. /recursive ..]
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.ReadFullObject[T](Int32 pos, Type typeOverride)
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.TryDeserialize[T](T& res, Type typeOverride)
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.Deserialize[T](Type typeOverride)
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.ReadBinaryObject[T](Boolean doDetach)
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.TryDeserialize[T](T& res, Type typeOverride)
   at Apache.Ignite.Core.Impl.Binary.BinaryReader.Deserialize[T](Type typeOverride)
   at Apache.Ignite.Core.Impl.Binary.Marshaller.Unmarshal[T](IBinaryStream stream, BinaryMode mode, BinaryObjectBuilder builder)
   at Apache.Ignite.Core.Impl.Binary.Marshaller.Unmarshal[T](IBinaryStream stream, Boolean keepBinary)
   at Apache.Ignite.Core.Impl.Client.Cache.CacheClient`2.UnmarshalNotNull[T](ClientResponseContext ctx)
   at Apache.Ignite.Core.Impl.Client.Cache.CacheClient`2.<GetAsync>b__2(ClientResponseContext ctx)
   at Apache.Ignite.Core.Impl.Client.ClientSocket.DecodeResponse[T](BinaryHeapStream stream, Func`2 readFunc, Func`3 errorFunc)
   at Apache.Ignite.Core.Impl.Client.ClientSocket.<>c__DisplayClass1`1.<DoOutInOpAsync>b__0(Task`1 responseTask)
[.. task dispatcher ..]
   at Perper.WebJobs.Extensions.Services.PerperFabricContext.WriteNotificationToChannel(Notification notification, String streamName, String parameterName) in /home/bobo/Projects/obecto/perper/functions/runtime/src/Perper.WebJobs.Extensions/Services/PerperFabricContext.cs:line 282
   at Perper.WebJobs.Extensions.Services.PerperFabricContext.RouteNotification(Notification notification) in /home/bobo/Projects/obecto/perper/functions/runtime/src/Perper.WebJobs.Extensions/Services/PerperFabricContext.cs:line 259
   at Perper.WebJobs.Extensions.Services.PerperFabricContext.<>c__DisplayClass9_1.<<StartListen>b__3>d.MoveNext() in /home/bobo/Projects/obecto/perper/functions/runtime/src/Perper.WebJobs.Extensions/Services/PerperFabricContext.cs:line 123

Added some logging in 0.5.2 (e33f9ce), and made sure that a deserialization failure does not cause a complete stop of message processing, which should help debug and handle instances of similar issues in the future.

As Newtonsoft.Json support is not blocking for 0.6, the milestone could be removed. A valid workaround for the time being is passing the value as a JSON-encoded String.