Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture the generical error on oasys widget #74

Open
2 tasks
capitanevs opened this issue Oct 1, 2021 · 4 comments
Open
2 tasks

Capture the generical error on oasys widget #74

capitanevs opened this issue Oct 1, 2021 · 4 comments
Assignees

Comments

@capitanevs
Copy link
Collaborator

capitanevs commented Oct 1, 2021

The two branches are supposed to be equal, but they return different results.

a) "kbh dpi" of branch A, generate an error, and GetBeamlineInfo return some results.
These results are not consistent with what is pecified in "kbh dpi". This behavior is strange.

b)"kbh dpi" of branch A, generate an error, and GetBeamlineInfo, if executed independently, also cast an error, as there is no input signal. This behavior is as expected.

What to do

  • Capture ANY error that is generated from wiser widget, so that:
    1) A "fake" output data is returned, containing at least the beamline (new feature)
    2) The error message is still displayed (as it is now)
    3) The execution is interrupted (as it is now)
  • Why is it happening a)? Obviously this behavior is not reproducible in an easy way.

immagine

@aljosahafner
Copy link
Collaborator

Yes, after reading a bit around this is perfectly fine behaviour. I will make the two try: except: statements and let the code continue executing even if the wavefront can't be calculated.

@capitanevs
Copy link
Collaborator Author

Great!

@aljosahafner
Copy link
Collaborator

I implemented this, can you share a workspace where the wavefront can't be calculated, but the beamline is fine?

@capitanevs
Copy link
Collaborator Author

To Be Continued

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants