Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making WISER work for everyone #63

Open
capitanevs opened this issue Sep 10, 2021 · 10 comments
Open

Making WISER work for everyone #63

capitanevs opened this issue Sep 10, 2021 · 10 comments
Labels
bug Something isn't working milestone Big feature

Comments

@capitanevs
Copy link
Collaborator

No description provided.

@capitanevs capitanevs added the bug Something isn't working label Sep 10, 2021
@capitanevs
Copy link
Collaborator Author

** TEST FILE1# "MARGOT 3" **
Notice

  • Rename the file from .LOG to .OWS
  • The file is set as readonly. This was meant to keep the data stored in the file as a "touchstone", and prevent from accidental change. You can change it on your laptop, if you want.

Goals are

  1. that the file is correctly opened and read by everyone
  2. that the values of the fields of the widget are correctly read. They should appear as in the comment textbox.
    Example if EllipticalMirror.F2 is 1.4, then things are fine. If F2 is 1.2, then things are wrong.

test_margot_03_READONLY.LOG

@maltissimo
Copy link

By opening the file test_margot_03_READONLY.ows (attached), both Oasys 1.2 and 1.3 give some errors. In particular:

Errors occurred while opening workflow:

UnknownWidgetDefinition('orangecontrib.wiser.widgets.light_sources.ow_gaussian_source_1d.OWGaussianSource1d')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_detector.OWDetector')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_slit.OWSlits')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')

By clicking OK on the Errror window I get:

CodeGenerated from Branch1

from LibWiser.EasyGo import*
Gaussian_Source =LibWiser.Foundation.OpticalElement( Name = 'Gaussian Source',
IsSource = True,
CoreOpticsElement =LibWiser.Optics.SourceGaussian( Lambda = 2.000000e-08,
Waist0 = 1.273240e-04,
M2 = 1.000000e+00,
AnglePropagation = 0.000000e+00,
Orientation = OPTICS_ORIENTATION.ANY,
),
PositioningDirectives =LibWiser.Foundation.PositioningDirectives( ReferTo = 'absolute',
PlaceWhat = None,
PlaceWhere = None,
GrazingAngle = None,
Distance = None,
),
)
Slit =LibWiser.Foundation.OpticalElement( Name = 'Slit',
IsSource = False,
CoreOpticsElement =LibWiser.Optics.Slits( L = 5.000000e-03,
AngleGrazing = 9.000000e+01,
Orientation = OPTICS_ORIENTATION.ANY,
),
PositioningDirectives =LibWiser.Foundation.PositioningDirectives( ReferTo = 'source',
PlaceWhat = 'centre',
PlaceWhere = 'centre',
GrazingAngle = None,
Distance = 9.700000e+01,
),
)
Elliptic_mirror =LibWiser.Foundation.OpticalElement( Name = 'Elliptic mirror',
IsSource = False,
CoreOpticsElement =LibWiser.Optics.MirrorElliptic( L = 3.000000e-01,
Alpha = 0.04363323129985824,
f1 = 9.900000e+01,
f2 = 1.400000e+00,
Orientation = OPTICS_ORIENTATION.ANY,
),
PositioningDirectives =LibWiser.Foundation.PositioningDirectives( ReferTo = 'source',
PlaceWhat = 'centre',
PlaceWhere = 'centre',
GrazingAngle = None,
Distance = 9.900000e+01,
),
)
Detector =LibWiser.Foundation.OpticalElement( Name = 'Detector',
IsSource = False,
CoreOpticsElement =LibWiser.Optics.Detector( L = 2.000000e-04,
AngleGrazing = 1.5707963267948966,
Orientation = OPTICS_ORIENTATION.ANY,
),
PositioningDirectives =LibWiser.Foundation.PositioningDirectives( ReferTo = 'upstream',
PlaceWhat = 'centre',
PlaceWhere = 'centre',
GrazingAngle = None,
Distance = 1.400000e+00,
),
)
WiserBeamline = BeamlineElements([Gaussian_Source, Slit, Elliptic_mirror, Detector])
WiserBeamline.RefreshPositions()

(see attached image)

Also, the figures have some issues, see attached images screenshot

Issue 63 files .zip

@capitanevs
Copy link
Collaborator Author

Comment:

all the part below seems to be nothing but the text contained in the comment box. I do not really know what it could mean...

@aljosahafner , how can we go bug-hunt?

CodeGenerated from Branch1

from LibWiser.EasyGo import*
Gaussian_Source =LibWiser.Foundation.OpticalElement( Name = 'Gaussian Source',
IsSource = True,
CoreOpticsElement =LibWiser.Optics.SourceGaussian( Lambda = 2.000000e-08,
Waist0 = 1.273240e-04,
M2 = 1.000000e+00,
AnglePropagation = 0.000000e+00,
Orientation = OPTICS_ORIENTATION.ANY,
),
PositioningDirectives =LibWiser.Foundation.PositioningDirectiv

@capitanevs capitanevs modified the milestones: k, Wiser 4 all platforms Sep 10, 2021
@capitanevs capitanevs added the milestone Big feature label Sep 10, 2021
@aljosahafner
Copy link
Collaborator

UnknownWidgetDefinition('orangecontrib.wiser.widgets.light_sources.ow_gaussian_source_1d.OWGaussianSource1d')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_detector.OWDetector')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_slit.OWSlits')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')
UnknownWidgetDefinition('orangecontrib.wiser.widgets.optical_elements.ow_elliptic_mirror.OWEllipticMirror')

This seems to me like a problem with Wiser installation...

@capitanevs
Copy link
Collaborator Author

capitanevs commented Sep 10, 2021 via email

@aljosahafner
Copy link
Collaborator

Our version is called OASYS1-Oasyswiser . The other one is the old one.

@capitanevs
Copy link
Collaborator Author

capitanevs commented Sep 10, 2021 via email

@aljosahafner
Copy link
Collaborator

If you mean OASYS1-Wiser, then no, because I am not a maintainer of the repository.

@capitanevs
Copy link
Collaborator Author

capitanevs commented Sep 10, 2021 via email

@aljosahafner
Copy link
Collaborator

If we get rights for OASYS1-Wiser, then it's ok, but otherwise I'd like to avoid any kind of renaming because it will introduce a lot of problems. AFAIK Luca doesn't like all capital letters...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working milestone Big feature
Projects
None yet
Development

No branches or pull requests

3 participants