Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FWHM/Spot size indicator #59

Open
capitanevs opened this issue Aug 27, 2021 · 10 comments
Open

FWHM/Spot size indicator #59

capitanevs opened this issue Aug 27, 2021 · 10 comments
Labels
new feature Completely new feature waitfollowup

Comments

@capitanevs
Copy link
Collaborator

In the minutes of issue #37 we decided to put an "info" section similar to that of SRW

It shall gather infos such that:
N of Samples,
HEW Spot size
FWHM Spot size

We have to decide where to put it and how.
-Where: a)the same location as SRW (making the plot smaller)? b)In another dedicated tab?
-How: a)with a nice GUI formatting (like SRW)? b)As formatted textual output?

I am for b+a or b+b

What do you think? Some other goodideas?

immagine

@capitanevs capitanevs added the new feature Completely new feature label Aug 27, 2021
@aljosahafner
Copy link
Collaborator

Let's discuss this in the meeting...

@capitanevs
Copy link
Collaborator Author

I am moving this here

Il 08/09/2021 13:52, Aljosa Hafner ha scritto:

Yes and no, depends what is inherited and what is new for a specific optical element and I also suspect this would ruin back compatibility with ows files...

On 9/8/21 1:50 PM, Michele Manfredda wrote:

Hi Aljosa,

if I create a function return a dictionary, e.g.
{'s': 1, 'lambda (nm)': 10, 'N Samples': 10000, 'HEW (um)': 40}

would it be easy for you to dynamially create the label + field entries in the GUI, so that you have:
[lambda ] ->[value]
[N Samples] -> [value]

etc..

?

@capitanevs
Copy link
Collaborator Author

My question (a little bit out of the blue), was in the context of "spot size indicator".

I'll reframe it here?

We agreed to add a new TAB on each optical element (possible name: "Spot Info").
The initial idea (for simplicity) was to add a big text box, where to put a string coming directly from libwiser.
This string would be something like:


Lambda = 12nm
N Samples = 3000
HEW = 12um
FWHM = xxx um

etc

As an alternative, we could create a Tab where we drop "lable + text box pairs" (as in SRW).
This should be quite simple if you put extra-intelligence on the widget to handle a dictionary (or a list of lables + list of values).

Q1: apart from backcompatibility, is this as simple as it seems to me? Do you see other objections?
Q2: about backcompatibility: good point! Wouldn't the first solution (new tab + text entry) break the backcompatibility as well?
Q3: Shall we do a quick test (add new tab + text input) to test backcompatibility?

@aljosahafner
Copy link
Collaborator

Now I understand. This is trivial for the GUI and very easy. If it's a separate tab then I think there shouldn't be any major issues, but we need to see.

First I thought you would like to change the way GUI is constructed.

@capitanevs
Copy link
Collaborator Author

Yeah, sorry, I was a little bit cryptical :-)

@capitanevs capitanevs reopened this Sep 8, 2021
@capitanevs
Copy link
Collaborator Author

I added
.ComputationData.Info

immagine

A code that takes the dictionary as input and produces a nicely formatted array of "label + text box" should nicely work with that.

@capitanevs
Copy link
Collaborator Author

(yep there is a problem in the FWHM... it is Mega-meters). The fit is wrong, I'll fix it later :-)

@aljosahafner
Copy link
Collaborator

aljosahafner commented Sep 8, 2021

Ok, excellent, I will make it tomorrow! Don't forget to push the code to github.

@capitanevs
Copy link
Collaborator Author

Yep, the code is pushed (and I hope it nicely merged with the warning suppression you did).

Perhaps... we can wait a little bit before doing that: I mean, we are just 1version away from the one that was correctly reading the ows file, so maybe we can keep the future in stanby, and inspect "the past" a little bit more :-)

@capitanevs
Copy link
Collaborator Author

Wait 3 follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Completely new feature waitfollowup
Projects
None yet
Development

No branches or pull requests

2 participants