Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter extraneous denominations from runtime transaction amounts #777

Open
pro-wh opened this issue Oct 22, 2024 · 0 comments
Open

Filter extraneous denominations from runtime transaction amounts #777

pro-wh opened this issue Oct 22, 2024 · 0 comments

Comments

@pro-wh
Copy link
Collaborator

pro-wh commented Oct 22, 2024

The Explorer team merged a PR to filter out extraneous denominations: oasisprotocol/explorer#1546

We can also do this in Nexus by checking the Amount denomination against the known denominations for each runtime according to the oasis-sdk.

[Andy] I'm a bit reluctant to start this since opinionated filtering/data manipulation was intentionally not in scope for Nexus. Nexus is intended to make on-chain data queryable, and downstream applications can filter/sort the data as needed. If possible we'd like this change to be made upstream in oasis-core, but already talked with them and it looks like sending 0 amounts of arbitrary tokens is allowed under evm standards and so the change won't be made upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant