-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
malware-behavior $refs URLs point to /malware-behavior/ instead of /malware-behavior-8e9/ #80
Comments
Part of the problem is that these are absolute URLs - the problem wouldn't be so profound if they were relative refs... |
@dunkeki - I made the changes to add 8e9 to the urls that were missing it. It is on the malware-behavior-8e9 branch. |
Missed one in extension-definition--8e9e338f-c9ee-4d4f-8cac-85b4dcfdf3c1.json, thanks. |
Done |
Since the $ref URLs are absolute to raw GitHub, I can't test. Things are probably correct (well, the current version is broken so merging what is probably correct is a good thing). Can you please merge? Thanks. If you know a way around this without merging, let me know... |
Those $ref should be relative. Then my local copy (which is corrected by you, thanks) would be used and work :( |
If you'd like, I can fix my local copy, get it working (AFAIK), and then post a tarball back to here... |
I'm not 100% sure why absolute urls were used, if it was necessary. Let me do the merge, then you can experiment. |
In addition to relativizing the $ref, there were a number of JSON errors in examples/behavior-unprotect.json (e.g. extra commas on a last array element, etc.). That file has been fixed as well (even though it won't pass schema validation - as intended - but the schema still work referencing each other etc.) Thanks! |
Don't know if these have been fixed by Charles et al, but they're broken in cti-stix-common-objects/extension-definition-specifications/malware-behavior-8e9/ ... thanks!
The text was updated successfully, but these errors were encountered: