Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending the VM initialization #250

Open
19 tasks
engelmi opened this issue Aug 3, 2023 · 1 comment
Open
19 tasks

Extending the VM initialization #250

engelmi opened this issue Aug 3, 2023 · 1 comment

Comments

@engelmi
Copy link
Contributor

engelmi commented Aug 3, 2023

Please describe what you would like to see

It would be great to have a complete set of functions to set all options in the VM initialization struct. Currently, only the custom-script and hostname are supported (and NicConfigurations will be partially added in #249).
A complete list of fields can be found in the documentation for oVirts REST API in the Initialization struct section.

Checklist for parameters

  • active_directory_ou
  • authorized_ssh_keys
  • cloud_init
  • cloud_init_network_protocol
  • configuration
  • dns_search
  • dns_servers
  • domain
  • input_locale
  • org_name
  • regenerate_ids
  • regenerate_ssh_keys
  • root_password
  • system_locale
  • timezone
  • ui_language
  • user_locale
  • user_name
  • windows_license_key

Please describe the solution you'd like

All additional parameters should optional and only be configurable via builder:

initialization := NewInitialization("custom-script", "hostname").WithSomeParam("some-param");
@dyens
Copy link

dyens commented Sep 13, 2023

Hi
@engelmi , I added boolean and string fields in vm.Initialization structure #253

I am thinking about cloud_init and cloud_init_network_protocol.

According https://www.ovirt.org/documentation/doc-REST_API_Guide/#types-initialization - this fields deprecated and maybe we should not implement this.

Implementation for vm.initialization.configuration.data field is complex for me. I try to make test for it and send some xml to ovirt (like in https://www.ovirt.org/documentation/doc-REST_API_Guide/#types-configuration example), but always i have (409) bad request. So i have no idea how to check this field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants