-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts for GitHub Pages Deployment in Tutorial 4 #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repo to asset urls for github deployment
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barriebyron
reviewed
Aug 3, 2023
…o repoURL variable to fix broken URL paths in CSS files
…i' for better clarity and documentation
barriebyron
reviewed
Aug 14, 2023
…nd double quote asset urls
…rve assets from a subdirectory when deployed to GitHub Pages
barriebyron
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for text, I did not test technical accuracy of code.
Just a few suggestions for wording
Co-authored-by: Barrie Byron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solution checks if the project is used locally only or is deployed in production
script CSS asset URLs require the repo name to be prepended to deploy to GitHub Pages correctly
package.json
npm run deploy
runs the script along with other commands to deploy to GitHub Pages