Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts for GitHub Pages Deployment in Tutorial 4 #558

Merged
merged 13 commits into from
Aug 17, 2023

Conversation

ymekuria
Copy link
Contributor

@ymekuria ymekuria commented Aug 3, 2023

solution checks if the project is used locally only or is deployed in production
script CSS asset URLs require the repo name to be prepended to deploy to GitHub Pages correctly

package.json

npm run deploy runs the script along with other commands to deploy to GitHub Pages

@ymekuria ymekuria requested a review from a team as a code owner August 3, 2023 20:00
@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 7:18pm

…o repoURL variable to fix broken URL paths in CSS files
@barriebyron barriebyron added the Tutorials How to, step-by-step developer walk throughs label Aug 15, 2023
…rve assets from a subdirectory when deployed to GitHub Pages
Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for text, I did not test technical accuracy of code.
Just a few suggestions for wording

@ymekuria ymekuria merged commit 6f40d98 into main Aug 17, 2023
@ymekuria ymekuria deleted the feature/tutorial-4-ghpages branch August 17, 2023 19:17
@ymekuria ymekuria self-assigned this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tutorials How to, step-by-step developer walk throughs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants