Skip to content

Commit acb0150

Browse files
committed
Fix some DX tests.
* DX value cells don't exist. * Don't conditionalize out tests based on platform. It's ok to fail. (Otherwise we never realize what does or doesn't work.) I'm pretty sure some of these work on the conditionalized out platforms now anyway, case in point.
1 parent 5a6e5d0 commit acb0150

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

tests/dynamic-extent.pure.lisp

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -172,10 +172,7 @@
172172
;;; value-cells
173173

174174
(defun-with-dx dx-value-cell (x)
175-
;; Not implemented everywhere, yet.
176-
#+(or arm64 x86 x86-64 mips)
177175
(let ((cell x))
178-
(declare (sb-int:truly-dynamic-extent cell))
179176
(flet ((f ()
180177
(incf cell)))
181178
(declare (dynamic-extent #'f))
@@ -330,7 +327,7 @@
330327
(sb-int:dx-let ((s (make-list-container :listy-slot (make-list n))))
331328
(values (funcall (the function thunk) s))))
332329
;; stack-allocatable lists are necessary but not sufficient
333-
(with-test (:name (:dx-list :make-list) :skipped-on (not :x86-64))
330+
(with-test (:name (:dx-list :make-list) :fails-on (not :x86-64))
334331
(let ((calls (ctu:asm-search "CALL" #'make-var-length-dx-list)))
335332
;; Call nothing but the funarg
336333
(assert (eql (length calls) 1)))
@@ -340,7 +337,7 @@
340337
;;; MAKE-STRUCTURE
341338

342339
;; stack-allocatable fixed-size objects are necessary but not sufficient
343-
(with-test (:name :copy-structure-dx :skipped-on (not (or :x86 :x86-64)))
340+
(with-test (:name :copy-structure-dx :fails-on (not (or :x86 :x86-64)))
344341
(let ((thing sb-c::*backend-parsed-vops*))
345342
;; check some preconditions
346343
(assert (typep thing 'hash-table))
@@ -874,7 +871,6 @@
874871
(assert (every (lambda (x) (eql x 0)) a))))
875872

876873
(with-test (:name (:dx-bug-misc :bdowning-2005-iv-16))
877-
#+(or arm64 mips x86 x86-64)
878874
(assert-no-consing (bdowning-2005-iv-16))
879875
(bdowning-2005-iv-16))
880876

@@ -929,7 +925,6 @@
929925
(multiple-value-bind (y pos2) (read-from-string res nil nil :start pos)
930926
(assert (equalp f2 y))
931927
(assert (equalp f3 (read-from-string res nil nil :start pos2))))))
932-
#+(or arm64 mips x86 x86-64)
933928
(assert-no-consing (assert (eql n (funcall fun nil))))
934929
(assert (eql n (funcall fun nil))))
935930

0 commit comments

Comments
 (0)