Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the Gaussian generator with the multivariate generator #336

Closed
ChristopherRabotin opened this issue Jul 10, 2024 · 2 comments
Closed
Labels
Kind: Improvement This is a proposed improvement Priority: high Status: Design Issue at Design phase of the quality assurance process Topic: Mission Design

Comments

@ChristopherRabotin
Copy link
Member

ChristopherRabotin commented Jul 10, 2024

Maintenance task description

There are two conflicting implementations of the Monte Carlo generator. Only one is mathematically correct: the multivariate generator. Work on #331 adds a spacecraft uncertainty structure to rotate from one frame into any other, and the KfEstimate also computes the uncertainty in any desired frame by using the OrbitDual structure to compute the partials.

The purpose of this issue is to allow a user to build a Multivariate generator using any orbital parameter, rotate that into the Cartesian state space, and disperse using that new inertial covariance.

Scope of work

This will likely lead to a fair amount of code being removed. It will probably lead to the specialization of the Monte Carlo structure to operate solely on spacecraft, but that is not an issue (if anything, it'll speed up the build time).

This issue will also replace the manual re-implementation of the multivariate distribution with nalgebra-mnv.

Priority

High

@ChristopherRabotin
Copy link
Member Author

Follow-on work in #339 .

@ChristopherRabotin
Copy link
Member Author

Done in #340.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: Improvement This is a proposed improvement Priority: high Status: Design Issue at Design phase of the quality assurance process Topic: Mission Design
Projects
None yet
Development

No branches or pull requests

1 participant