Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control spacing before separator #1493

Open
simonleadbetter opened this issue Jul 16, 2024 · 2 comments
Open

Control spacing before separator #1493

simonleadbetter opened this issue Jul 16, 2024 · 2 comments

Comments

@simonleadbetter
Copy link

For improved a11y, we prefer to use a comma as a separator than the default | pipe character as screen readers will read vertical line, but they will ignore punctuation like a comma.

We change the default separator using the separatorChar config override; however, this leaves a space between the title and the comma. It would be great if the value of the separator honoured spacing, i.e: ', ' rather than it be programatically added.

@khalwat
Copy link
Collaborator

khalwat commented Jul 17, 2024

Well, it's a separator character, not a string. I'm assuming this is mostly a cosmetic issue, in that it displays a little weird visually when you're using a comma?

I guess I could special-case it and remove the space if the character happens to be a comma, but it feels odd.

@simonleadbetter
Copy link
Author

Hi Andrew. Yup. A client spotted the space and requested its removal. Ideally we would prefer to keep the comma as it creates a better experience for screen readers, so if you could tweak the rendering that that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants