Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Support Vizy fields as meta source fields #1115

Open
yoannisj opened this issue Apr 16, 2022 · 10 comments
Open

[FR] Support Vizy fields as meta source fields #1115

yoannisj opened this issue Apr 16, 2022 · 10 comments

Comments

@yoannisj
Copy link

Describe the bug

Vizy fields don't appear in source field dropdowns in the Content SEO settings for entry sections.

To reproduce

  1. Add a Vizy field to a given Entry Type
  2. Go to SEOMatic > Content SEO > Entry Section from Step 1
  3. Select the Entry Type from Step 1 in the dropdown on the top left
  4. Select "SEO Description Source > From Field"
  5. Open the "Source Field" dropdown
  6. The Vizy field from Step 1 is not listed in the dropdown options

Expected behaviour

Vizy fields can contain text which may be useful for SEO descriptions. It would be great if we could select Vizy fields as SEO field sources, for both the "From Field" and "Summary from Field" options.

Versions

  • SEOMatic version: 3.4.24
  • Vizy version: 1.0.12
  • Craft version: 3.7.32
@yoannisj yoannisj added the bug label Apr 16, 2022
@khalwat
Copy link
Collaborator

khalwat commented Apr 17, 2022

Changing this to a feature request

@khalwat khalwat added enhancement and removed bug labels Apr 17, 2022
@khalwat khalwat changed the title Vizy fields are not supported as source fields [FR] Vizy fields are not supported as source fields Apr 17, 2022
@yoannisj yoannisj changed the title [FR] Vizy fields are not supported as source fields [FR] Support Vizy fields as meta source fields Apr 18, 2022
@engram-design
Copy link
Contributor

@khalwat Is there a mechanism for me to add support for Vizy fields, or is that all more or less hardcoded on your end?

@khalwat
Copy link
Collaborator

khalwat commented Aug 15, 2022

Hard-coded-ish on my end, but shouldn't be too hard for me to add here: https://github.com/nystudio107/craft-seomatic/blob/develop/src/helpers/Field.php & https://github.com/nystudio107/craft-seomatic/blob/develop/src/helpers/Text.php

@yoannisj
Copy link
Author

yoannisj commented Oct 17, 2022

Just realised that it would make sense to support Vizy field as source for Asset fields in sitemaps:

We often use Vizy fields as rich text fields (i.e. without adding any block type) because of how it stores the formatted the text as JSON (which gives us more control on how to render the field in the frontend).

For example: in the screenshot below Assets in the "Images" volume have a block-less Vizy field named "Description" where editors can add a caption to the images. The text stored in that field would be the best match for the Asset's "Caption" field in sitemaps, but it is currently not selectable:

ScreenShot 2022-10-17 at 11 21 30

@gregorydavidjenkins
Copy link

Would also love to be able to add a Vizy field as the source for SEO description. Specifically "Summary from field".

@khalwat
Copy link
Collaborator

khalwat commented Nov 9, 2022

Very doable

@torgeirbeyer
Copy link

Any updates on this?

@khalwat
Copy link
Collaborator

khalwat commented Mar 15, 2023

I'm planning to slate this for the next release!

@torgeirbeyer
Copy link

Has this been released @khalwat ?

@khalwat
Copy link
Collaborator

khalwat commented Nov 28, 2023

Not yet; sorry for promising it in the next release, and not delivering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants