fix: scan dotfiles in source paths #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
approved these changes
Oct 18, 2024
|
I would suggest add gitignore for some of the known dot files. Or ideally parse .gitignore to avoid unwanted behavior or at least reduce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves nuxt/module-builder#400
Might be worth more discussion about whether this is desired, or a breaking change.
(Nevertheless it should be possible to override by using an array pattern syntax to exclude files matching a dot pattern. Alternatively, we could allow configuring glob options more specifically - but it feels like the pattern syntax is a safer API.)