Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adobe fonts provider #11

Closed
danielroe opened this issue Feb 22, 2024 · 2 comments · Fixed by #55
Closed

adobe fonts provider #11

danielroe opened this issue Feb 22, 2024 · 2 comments · Fixed by #55
Assignees
@qwerzl
Labels
enhancement New feature or request provider

Comments

@danielroe
Copy link
Member

No description provided.

@danielroe danielroe added enhancement New feature or request provider labels Feb 22, 2024
@qwerzl
Copy link
Member

qwerzl commented Mar 11, 2024 •
edited
Loading

@danielroe If nobody's working on this, I'd love to work on this provider.

I'm currently thinking about specifying a kit id in the module config, then in providers/adobe.ts get the info of this kit (weights, families) as metadata and add all the fonts provided by the kit's CSS if one of the requested fonts matches because Adobe Fonts doesn't provide an endpoint to get CSS for a single font.

Also, there is an older Adobe Fonts API on https://fonts.adobe.com/docs/api/kits. Looks like the newer one requires an API key to access it. Is it okay to use the older API endpoints?

@danielroe
Copy link
Member Author

That would be great! It looks like we can use the older API, they just encourage use of the new one.

@qwerzl qwerzl mentioned this issue Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwerzl qwerzl

Labels
enhancement New feature or request provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adobe fonts provider
2 participants
@danielroe @qwerzl