Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Coordinates-based Cropping #230

Closed
colbyfayock opened this issue Sep 4, 2024 · 8 comments · Fixed by #246
Closed

[Feature] Coordinates-based Cropping #230

colbyfayock opened this issue Sep 4, 2024 · 8 comments · Fixed by #246
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Tasks that can be taken during Hacktoberfest

Comments

@colbyfayock
Copy link
Collaborator

Feature Request

Is your feature request related to a problem? Please describe.

Add support for coordinates-based cropping.

crop={{
  type: 'crop',
  width: 400,
  height: 400,
  x: 80,
  y: 350,
  gravity: 'north_east',
  source: true
}}

change is available inside of @cloudinary-util/[email protected], should just need to update documentation and add an example as it makes sense.

cloudinary-community/next-cloudinary#509
https://next.cloudinary.dev/cldimage/examples#cropping

@colbyfayock colbyfayock added the enhancement New feature or request label Sep 4, 2024
@Baroshem Baroshem added good first issue Good for newcomers hacktoberfest Tasks that can be taken during Hacktoberfest labels Sep 9, 2024
@nooras
Copy link

nooras commented Oct 5, 2024

hey @colbyfayock @Baroshem
I am interested in this task. Can you please assign me?
Also it would be great if you guys can provide more details and examples.

In local after clone and install it looks like this!!
Can you help me for local setup?
Image

@Baroshem
Copy link
Collaborator

Baroshem commented Oct 6, 2024

Hey there @nooras

Yes, feel free to grab it! What you see when running the project is ok. It is a playground of all modules features. Feel free to comment the ones that you dont need and work only on the ones related to the issue :)

I dont think there are more details or examples here. Colby explained everythin pretty clear :)

@nooras
Copy link

nooras commented Oct 6, 2024

Hey there @nooras

Yes, feel free to grab it! What you see when running the project is ok. It is a playground of all modules features. Feel free to comment the ones that you dont need and work only on the ones related to the issue :)

I dont think there are more details or examples here. Colby explained everythin pretty clear :)

@Baroshem
I didn't get!! How to start local that it should look similar to https://cloudinary.nuxtjs.org/ ?
If I make some changes then it should reflect in local. Right? Then only I know whatever I have added its working fine!!

@Baroshem
Copy link
Collaborator

Baroshem commented Oct 7, 2024

What you are refering to is the documentation of the module while running pnpm run dev you are runing the playground. To run the documentation you should type pnpm run docs.

But to implement it, first you would need to develop a new functionality and test it in playground and then later on add it to the documentation.

@Baroshem
Copy link
Collaborator

@nooras Can I do something else to help you get started?

@nooras
Copy link

nooras commented Oct 11, 2024

@nooras Can I do something else to help you get started?

I am still not able to see in local with pnpm run docs. Its coming like below.
Image

Also any docs to refer how to use playground ?

@Baroshem
Copy link
Collaborator

Could you check what are the errors when running the project?

For the second one, there are no docs because playground is just a simple app for testing the module components and composables. You can just add there whatever you want to test :)

@nooras
Copy link

nooras commented Oct 11, 2024

@Baroshem can you please check your discord

Baroshem added a commit that referenced this issue Nov 4, 2024
@Baroshem Baroshem mentioned this issue Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Tasks that can be taken during Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants