Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

short_name uses package.json name by default instead of manifest name #544

Open
PetroSilenius opened this issue May 11, 2023 · 0 comments
Open

Comments

@PetroSilenius
Copy link

Currently if short_name is not provided in the manifest config it will default to package.json name

short_name: process.env.npm_package_name,

While docs describe this behaviour like this
The short_name (maximum of 12 characters recommended) is a short version of the app's name. It is an optional field and if not specified, the name will be used, > though it will likely be truncated.
https://pwa.nuxtjs.org/manifest#short_name

Based on docs I got the impression that the default value for short_name would be the name property in the pwa manifest but that doesn't appear to be the case.

Which one is wanted behaviour here? Should the docs be updated to match current behaviour or should the implementation be updated to match docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant