Skip to content

Commit f0d55cd

Browse files
committed
Rename Remote API to Engine API
Implementation of moby#28319 Signed-off-by: Ben Firshman <[email protected]>
1 parent 993854f commit f0d55cd

File tree

33 files changed

+92
-100
lines changed

33 files changed

+92
-100
lines changed

api/swagger.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,18 @@ consumes:
1010
- "text/plain"
1111
basePath: "/v1.26"
1212
info:
13-
title: "Docker Remote API"
13+
title: "Docker Engine API"
1414
version: "1.26"
1515
x-logo:
1616
url: "https://docs.docker.com/images/logo-docker-main.png"
1717
description: |
18-
The Docker API is an HTTP REST API served by Docker Engine. It is the API the Docker client uses to communicate with the Engine, so everything the Docker client can do can be done with the API.
18+
The Engine API is an HTTP REST API served by Docker Engine. It is the API the Docker client uses to communicate with the Engine, so everything the Docker client can do can be done with the API.
1919
20-
Most of the client's commands map directly to API endpoints (e.g. `docker ps` is `GET /containers/json`). The notable exception is running containers, which consists of several API calls. [There is example of using `curl` to run a container in the SDK documentation.](#TODO)
20+
Most of the client's commands map directly to API endpoints (e.g. `docker ps` is `GET /containers/json`). The notable exception is running containers, which consists of several API calls.
2121
2222
# Errors
2323
24-
The Remote API uses standard HTTP status codes to indicate the success or failure of the API call. The body of the response will be JSON in the following format:
24+
The API uses standard HTTP status codes to indicate the success or failure of the API call. The body of the response will be JSON in the following format:
2525
2626
```
2727
{
@@ -1262,7 +1262,7 @@ definitions:
12621262
x-nullable: false
12631263

12641264
Plugin:
1265-
description: "A plugin for the Remote API"
1265+
description: "A plugin for the Engine API"
12661266
type: "object"
12671267
required: [Settings, Enabled, Config, Name, Tag]
12681268
properties:

api/types/client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ type SecretRequestOption struct {
351351
Mode os.FileMode
352352
}
353353

354-
// SwarmUnlockKeyResponse contains the response for Remote API:
354+
// SwarmUnlockKeyResponse contains the response for Engine API:
355355
// GET /swarm/unlockkey
356356
type SwarmUnlockKeyResponse struct {
357357
// UnlockKey is the unlock key in ASCII-armored format.

api/types/plugin.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package types
33
// This file was generated by the swagger tool.
44
// Editing this file might prove futile when you re-run the swagger generate command
55

6-
// Plugin A plugin for the Remote API
6+
// Plugin A plugin for the Engine API
77
// swagger:model Plugin
88
type Plugin struct {
99

api/types/plugin_responses.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
"fmt"
66
)
77

8-
// PluginsListResponse contains the response for the remote API
8+
// PluginsListResponse contains the response for the Engine API
99
type PluginsListResponse []*Plugin
1010

1111
const (

api/types/types.go

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ import (
1717
"github.com/docker/go-connections/nat"
1818
)
1919

20-
// ContainerChange contains response of Remote API:
20+
// ContainerChange contains response of Engine API:
2121
// GET "/containers/{name:.*}/changes"
2222
type ContainerChange struct {
2323
Kind int
2424
Path string
2525
}
2626

27-
// ImageHistory contains response of Remote API:
27+
// ImageHistory contains response of Engine API:
2828
// GET "/images/{name:.*}/history"
2929
type ImageHistory struct {
3030
ID string `json:"Id"`
@@ -35,7 +35,7 @@ type ImageHistory struct {
3535
Comment string
3636
}
3737

38-
// ImageDelete contains response of Remote API:
38+
// ImageDelete contains response of Engine API:
3939
// DELETE "/images/{name:.*}"
4040
type ImageDelete struct {
4141
Untagged string `json:",omitempty"`
@@ -56,7 +56,7 @@ type RootFS struct {
5656
BaseLayer string `json:",omitempty"`
5757
}
5858

59-
// ImageInspect contains response of Remote API:
59+
// ImageInspect contains response of Engine API:
6060
// GET "/images/{name:.*}/json"
6161
type ImageInspect struct {
6262
ID string `json:"Id"`
@@ -79,7 +79,7 @@ type ImageInspect struct {
7979
RootFS RootFS
8080
}
8181

82-
// Container contains response of Remote API:
82+
// Container contains response of Engine API:
8383
// GET "/containers/json"
8484
type Container struct {
8585
ID string `json:"Id"`
@@ -101,7 +101,7 @@ type Container struct {
101101
Mounts []MountPoint
102102
}
103103

104-
// CopyConfig contains request body of Remote API:
104+
// CopyConfig contains request body of Engine API:
105105
// POST "/containers/"+containerID+"/copy"
106106
type CopyConfig struct {
107107
Resource string
@@ -118,28 +118,28 @@ type ContainerPathStat struct {
118118
LinkTarget string `json:"linkTarget"`
119119
}
120120

121-
// ContainerStats contains response of Remote API:
121+
// ContainerStats contains response of Engine API:
122122
// GET "/stats"
123123
type ContainerStats struct {
124124
Body io.ReadCloser `json:"body"`
125125
OSType string `json:"ostype"`
126126
}
127127

128-
// ContainerProcessList contains response of Remote API:
128+
// ContainerProcessList contains response of Engine API:
129129
// GET "/containers/{name:.*}/top"
130130
type ContainerProcessList struct {
131131
Processes [][]string
132132
Titles []string
133133
}
134134

135-
// Ping contains response of Remote API:
135+
// Ping contains response of Engine API:
136136
// GET "/_ping"
137137
type Ping struct {
138138
APIVersion string
139139
Experimental bool
140140
}
141141

142-
// Version contains response of Remote API:
142+
// Version contains response of Engine API:
143143
// GET "/version"
144144
type Version struct {
145145
Version string
@@ -161,7 +161,7 @@ type Commit struct {
161161
Expected string
162162
}
163163

164-
// Info contains response of Remote API:
164+
// Info contains response of Engine API:
165165
// GET "/info"
166166
type Info struct {
167167
ID string
@@ -339,7 +339,7 @@ type ContainerNode struct {
339339
Labels map[string]string
340340
}
341341

342-
// ContainerJSONBase contains response of Remote API:
342+
// ContainerJSONBase contains response of Engine API:
343343
// GET "/containers/{name:.*}/json"
344344
type ContainerJSONBase struct {
345345
ID string `json:"Id"`
@@ -500,7 +500,7 @@ type Runtime struct {
500500
Args []string `json:"runtimeArgs,omitempty"`
501501
}
502502

503-
// DiskUsage contains response of Remote API:
503+
// DiskUsage contains response of Engine API:
504504
// GET "/system/df"
505505
type DiskUsage struct {
506506
LayersSize int64
@@ -509,49 +509,49 @@ type DiskUsage struct {
509509
Volumes []*Volume
510510
}
511511

512-
// ImagesPruneConfig contains the configuration for Remote API:
512+
// ImagesPruneConfig contains the configuration for Engine API:
513513
// POST "/images/prune"
514514
type ImagesPruneConfig struct {
515515
DanglingOnly bool
516516
}
517517

518-
// ContainersPruneConfig contains the configuration for Remote API:
518+
// ContainersPruneConfig contains the configuration for Engine API:
519519
// POST "/images/prune"
520520
type ContainersPruneConfig struct {
521521
}
522522

523-
// VolumesPruneConfig contains the configuration for Remote API:
523+
// VolumesPruneConfig contains the configuration for Engine API:
524524
// POST "/images/prune"
525525
type VolumesPruneConfig struct {
526526
}
527527

528-
// NetworksPruneConfig contains the configuration for Remote API:
528+
// NetworksPruneConfig contains the configuration for Engine API:
529529
// POST "/networks/prune"
530530
type NetworksPruneConfig struct {
531531
}
532532

533-
// ContainersPruneReport contains the response for Remote API:
533+
// ContainersPruneReport contains the response for Engine API:
534534
// POST "/containers/prune"
535535
type ContainersPruneReport struct {
536536
ContainersDeleted []string
537537
SpaceReclaimed uint64
538538
}
539539

540-
// VolumesPruneReport contains the response for Remote API:
540+
// VolumesPruneReport contains the response for Engine API:
541541
// POST "/volumes/prune"
542542
type VolumesPruneReport struct {
543543
VolumesDeleted []string
544544
SpaceReclaimed uint64
545545
}
546546

547-
// ImagesPruneReport contains the response for Remote API:
547+
// ImagesPruneReport contains the response for Engine API:
548548
// POST "/images/prune"
549549
type ImagesPruneReport struct {
550550
ImagesDeleted []ImageDelete
551551
SpaceReclaimed uint64
552552
}
553553

554-
// NetworksPruneReport contains the response for Remote API:
554+
// NetworksPruneReport contains the response for Engine API:
555555
// POST "/networks/prune"
556556
type NetworksPruneReport struct {
557557
NetworksDeleted []string

client/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Go client for the Docker Remote API
1+
# Go client for the Docker Engine API
22

33
The `docker` command uses this package to communicate with the daemon. It can also be used by your own Go applications to do anything the command-line interface does – running containers, pulling images, managing swarms, etc.
44

client/client.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
/*
2-
Package client is a Go client for the Docker Remote API.
2+
Package client is a Go client for the Docker Engine API.
33
44
The "docker" command uses this package to communicate with the daemon. It can also
55
be used by your own Go applications to do anything the command-line interface does
66
- running containers, pulling images, managing swarms, etc.
77
8-
For more information about the Remote API, see the documentation:
9-
https://docs.docker.com/engine/reference/api/docker_remote_api/
8+
For more information about the Engine API, see the documentation:
9+
https://docs.docker.com/engine/reference/api/
1010
1111
Usage
1212

container/container.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ func (DetachError) Error() string {
7070
type CommonContainer struct {
7171
StreamConfig *stream.Config
7272
// embed for Container to support states directly.
73-
*State `json:"State"` // Needed for remote api version <= 1.11
73+
*State `json:"State"` // Needed for Engine API version <= 1.11
7474
Root string `json:"-"` // Path to the "home" of the container, including metadata.
7575
BaseFS string `json:"-"` // Path to the graphdriver mountpoint
7676
RWLayer layer.RWLayer `json:"-"`

contrib/completion/fish/docker.fish

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ function __fish_print_docker_repositories --description 'Print a list of docker
4343
end
4444

4545
# common options
46-
complete -c docker -f -n '__fish_docker_no_subcommand' -l api-cors-header -d "Set CORS headers in the remote API. Default is cors disabled"
46+
complete -c docker -f -n '__fish_docker_no_subcommand' -l api-cors-header -d "Set CORS headers in the Engine API. Default is cors disabled"
4747
complete -c docker -f -n '__fish_docker_no_subcommand' -s b -l bridge -d 'Attach containers to a pre-existing network bridge'
4848
complete -c docker -f -n '__fish_docker_no_subcommand' -l bip -d "Use this CIDR notation address for the network bridge's IP, not compatible with -b"
4949
complete -c docker -f -n '__fish_docker_no_subcommand' -s D -l debug -d 'Enable debug mode'

contrib/completion/zsh/_docker

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2200,7 +2200,7 @@ __docker_subcommand() {
22002200
_arguments $(__docker_arguments) \
22012201
$opts_help \
22022202
"($help)*--add-runtime=[Register an additional OCI compatible runtime]:runtime:__docker_complete_runtimes" \
2203-
"($help)--api-cors-header=[CORS headers in the remote API]:CORS headers: " \
2203+
"($help)--api-cors-header=[CORS headers in the Engine API]:CORS headers: " \
22042204
"($help)*--authorization-plugin=[Authorization plugins to load]" \
22052205
"($help -b --bridge)"{-b=,--bridge=}"[Attach containers to a network bridge]:bridge:_net_interfaces" \
22062206
"($help)--bip=[Network bridge IP]:IP address: " \

0 commit comments

Comments
 (0)