Add support for Assert.EnterMultipleScope #816
Merged
+235
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When referencing NUnit >= 4.2.0
And When referencing NUnit 3.14.0: |
manfred-brands
force-pushed
the
Issue769_EnterMultipleScope
branch
from
23a6195 to
9fef008
Compare
mikkelbu
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Looks great. I'm happy to merge this when you are. Thanks for the improvement @manfred-brands
src/nunit.analyzers/UseAssertMultiple/UseAssertMultipleCodeFix.cs
Outdated
Show resolved
Hide resolved
| @@ -45,6 +45,38 @@ await Assert.MultipleAsync(async () => | |||
| }"); | |||
| RoslynAssert.Valid(this.analyzer, testCode); | |||
| } | |||
|
|
|||
| #if WOULD_SOMEONE_ACTUALLY_USE_THIS | |||
There was a problem hiding this comment.
Is there a reason for why we wouldn't want to run this test :) ?
There was a problem hiding this comment.
Yes, it won't work as we don't have support for it.
It would require tracking the declared variable and check if it is manually disposed somewhere within the scope.
Unless someone has a good reason for using this pattern, I don't see any, I won't spend my time on it.
Allow the user to select the Assert.Multiple codefix
manfred-brands
force-pushed
the
Issue769_EnterMultipleScope
branch
from
9fef008 to
cf7eacb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #769
Detects that code inside a
using (Assert.EnterMultipleScope())is inside a multiple context.Adds a codefix for to use
Assert.EnterMultipleScope.