Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Remame --timeout option (and associated EnginePackageSettings) #890

Closed
ChrisMaddock opened this issue Jan 30, 2021 · 3 comments · Fixed by #1145
Closed

v4: Remame --timeout option (and associated EnginePackageSettings) #890

ChrisMaddock opened this issue Jan 30, 2021 · 3 comments · Fixed by #1145
Assignees
Milestone

Comments

@ChrisMaddock
Copy link
Member

To permit #437. --timeout is ambiguous as to whether it refers to the timeout of the full test run, or an individual test. I suggest renaming the option in v4: potentially --defaultTestTimeout?

@CharliePoole
Copy link
Collaborator

Yes. i'd look at the internal names too, including those used as TestPackage settings.

@CharliePoole
Copy link
Collaborator

@jnm2 @mikkelbu @rprouse

I lean toward "TestCase" rather than "Test" but --defaultTestCaseTimeout is rather long. What about just --testCaseTimeout?

@jnm2
Copy link
Collaborator

jnm2 commented Feb 18, 2022

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants