Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: sequence index popup error should be part of error/warn system #476

Open
katestange opened this issue Oct 26, 2024 · 1 comment
Open
Labels
meeting To be discussed at weekly meeting sequence Related to a sequence or the sequence subsystem ui Something having to do with the user interface

Comments

@katestange
Copy link
Member

Go to this url:
http://localhost:5173/?name=ModFill&viz=ModFill&modDimension=200&seq=Formula&formula=n%21
And then try to make the index negative. Type - in the sequence index box and an appropriate error is displayed. Follow that up by typing 1 (so it should show -1), and instead we get a popup error message, as follows:
Screenshot from 2024-10-26 15-11-31
I think that such an error ought to be part of the error/warn system, not a show-stopping pop-up. But note that it's important we are using the formula n! to cause this -- it appears to come from math.js or somewhere, because using a formula like n doesn't have this behaviour. So maybe this is about handling mathjs complaints better?

@katestange katestange added the bug Something isn't working label Oct 26, 2024
@gwhitney
Copy link
Collaborator

Yup, this is all about mathjs. I don't think there's any possible way we can detect what combinations of formulas and indices will cause mathjs to throw errors. So this is not a parameter validation problem. Hence it is not a "bug" per se; all error-throwing is handled by these pop-ups. In other words, the designed behavior is occurring. Hence, I am changing the label to UI and adding "meeting" so we can discuss this sometime. I am fine with this not having any particular alpha/beta designation, but if you think it should be for one of the milestones, go ahead and label it as such. Thanks.

@gwhitney gwhitney added ui Something having to do with the user interface meeting To be discussed at weekly meeting sequence Related to a sequence or the sequence subsystem and removed bug Something isn't working labels Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting To be discussed at weekly meeting sequence Related to a sequence or the sequence subsystem ui Something having to do with the user interface
Projects
None yet
Development

No branches or pull requests

2 participants