Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

Types for custom-protocol-detection-blockstack #5

Open
vsund opened this issue Mar 16, 2018 · 0 comments
Open

Types for custom-protocol-detection-blockstack #5

vsund opened this issue Mar 16, 2018 · 0 comments
Labels
area/port Item concerns the port from blockstack.js

Comments

@vsund
Copy link
Member

vsund commented Mar 16, 2018

@larry, currently looking into custom-protocol-detection-blockstack and writing a type declaration for it, but wondering where it gets its name from (the name is still custom-protocol-detection in your fork).

Have written a (really) basic declaration

/**
 * Checks whether a given protocol handler exists and performs corresponding actions
 * 
 * @param protocolURI Protocol URI to check for
 * @param failCallback Callback function to execute when the protocol handler doesn't existt
 * @param successCallback Callback function to execute when the protocol handler exists
 * @param unsupportedBrowserCallback Callback function to execute when found an unsupported browser
 */
export declare function protocolCheck(
    protocolURI: string, failCallback: () => void, successCallback: () => void, unsupportedBrowserCallback: () => void
): void;

but getting problems when trying to yarn link my fork of your fork into my port (:sweat_smile:).

Am I missing something here? (Fixed it for now with manually symlinking my fork.)

Edit: Types are live in my fork at https://github.com/vsund/custom-protocol-detection/tree/feature/add-typescript-declarations (that's what I manually symlinked into the project).

@vsund vsund mentioned this issue Mar 16, 2018
26 tasks
@vsund vsund added the area/port Item concerns the port from blockstack.js label Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/port Item concerns the port from blockstack.js
Projects
None yet
Development

No branches or pull requests

1 participant