Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

Clarify needed dependencies #4

Open
vsund opened this issue Mar 16, 2018 · 0 comments
Open

Clarify needed dependencies #4

vsund opened this issue Mar 16, 2018 · 0 comments
Labels
area/port Item concerns the port from blockstack.js size/small Item requires not much work

Comments

@vsund
Copy link
Member

vsund commented Mar 16, 2018

blockstack.js at commit 286df82 has the following dependencies:

More

dependencies

  • "ajv": "^4.11.5"
  • "bigi": "^1.4.2"
  • "bitcoinjs-lib": "^2.3.0"
  • "cheerio": "^0.22.0"
  • "custom-protocol-detection-blockstack": "1.1.3"
  • "ecurve": "^1.0.6"
  • "elliptic": "^6.4.0"
  • "es6-promise": "^4.2.4"
  • "hasprop": "0.0.4"
  • "isomorphic-fetch": "^2.2.1"
  • "jsontokens": "^0.7.7"
  • "promise": "^7.1.1"
  • "query-string": "^4.3.2"
  • "request": "^2.79.0"
  • "ripemd160": "^2.0.1"
  • "schema-inspector": "^1.6.4"
  • "sprintf-js": "^1.0.3"
  • "uri-js": "^3.0.2"
  • "uuid": "^3.2.1"
  • "validator": "^7.0.0"
  • "zone-file": "^0.2.2"

devDependencies

  • "babel-cli": "^6.24.1"
  • "babel-eslint": "^6.0.4"
  • "babel-preset-env": "^1.6.1"
  • "babel-preset-flow": "^6.23.0"
  • "blue-tape": "^1.0.0"
  • "browserify": "^13.1.1"
  • "documentation": "^4.0.0-rc.1"
  • "eslint": "^2.10.2"
  • "eslint-config-airbnb": "^9.0.1"
  • "eslint-plugin-import": "^1.8.1"
  • "eslint-plugin-jsx-a11y": "^1.2.2"
  • "eslint-plugin-react": "^5.1.1"
  • "express": "^4.15.0"
  • "fetch-mock": "^5.5.0"
  • "flow-bin": "^0.49.1"
  • "mock-local-storage": "^1.0.5"
  • "nock": "^9.1.6"
  • "node-fetch": "^1.6.3"
  • "nyc": "^11.4.1"
  • "opn": "^4.0.2"
  • "proxyquire": "^1.8.0"
  • "sinon": "^4.2.1"
  • "tape": "^4.6.3"
  • "tape-promise": "^2.0.1

When compiling the code, tsc only complaints about:

  • 'bigi'
  • 'bitcoinjs-lib'
  • 'cheerio'
  • 'custom-protocol-detection-blockstack'
  • 'ecurve'
  • 'elliptic'
  • 'form-data'
  • 'hasprop'
  • 'isomorphic-fetch'
  • 'jsontokens'
  • 'query-string'
  • 'schema-inspector'
  • 'uri-js'
  • 'zone-file'

(Bash magic: yarn build | grep "Cannot find module" | grep -E "'[a-z-]+'" -o | sort -u)

Comparing these against the dependencies leaves the following packages over:

  • ajv
  • es6-promise
  • promise
  • request
  • sprintf-js
  • uuid
  • validator

It appears that these are unused dependencies. Wondering whether (1) this is correct and (2) if there can be safely removed or are there on purpose.

Furthermore tsc complaints about missing form-data, which isn't listed as dependency (but though finds its way into node_modules/). I think this gets pulled in as a dependency for another package.
Again the question, is it correct that the package is missing?

@vsund vsund mentioned this issue Mar 16, 2018
26 tasks
vsund added a commit that referenced this issue Mar 16, 2018
@vsund vsund added area/port Item concerns the port from blockstack.js size/small Item requires not much work labels Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/port Item concerns the port from blockstack.js size/small Item requires not much work
Projects
None yet
Development

No branches or pull requests

1 participant