Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqd: add support for configurable max-defer-delay for Deferred Publish #1499

Open
c3llus opened this issue Oct 24, 2024 · 1 comment
Open
Labels

Comments

@c3llus
Copy link

c3llus commented Oct 24, 2024

TL;DR

Currently, NSQD does not support a dedicated max-defer-delay configuration for deferred publish operations. Instead, deferred publish times are implicitly governed by the --max-req-timeout configuration, which (I believe) was originally intended for requeueing messages? This creates a bit of confusion since requeueing and deferring are two different operations. Ideally, there should be a dedicated setting to control the maximum defer time.

Proposed Changes

Add a new --max-defer-delay config for NSQD, which specifically limits deferred publish times without affecting the requeue timeout. This would make the system more flexible and reduce the confusion between the two operations.


Next Steps: If this sounds good, I’d love to help by submitting a PR to implement it. This is one of my first contributions to open source, so I would really appreciate any feedback and help from the maintainers to make sure everything is on track!

@c3llus c3llus changed the title nsqd: add support for configurable max-defer-time for DPUB in NSQD nsqd: add support for configurable max-defer-delay for Deferred Publish Oct 24, 2024
@mreiferson
Copy link
Member

Yea this sounds good, feel free to submit a PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants