Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 ACL default behavior test #885

Closed
roman-khimov opened this issue Oct 28, 2024 · 4 comments · Fixed by #894
Closed

S3 ACL default behavior test #885

roman-khimov opened this issue Oct 28, 2024 · 4 comments · Fixed by #894
Assignees
@evgeniiz321
Labels
feature Completely new functionality I2 Regular impact S4 Routine U2 Seriously planned

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when we don't have any tests for nspcc-dev/neofs-s3-gw#1016.

Describe the solution you'd like

Add 0.32.1+ test that will:

  • check the default ACL
  • check PUTs without ACL and with owner-control ACL (many of these, trying to reproduce EACL bloat which can be tested with S3 0.32.0, it's degrading quickly)
  • check PUTs with other ACLs that MUST fail unless we enable ACLs explicitly

This intersects with S3 testcases and s3-tests we already have.
@roman-khimov roman-khimov added U2 Seriously planned S4 Routine I2 Regular impact feature Completely new functionality labels Oct 28, 2024
@roman-khimov
Copy link
Member Author

private canned ACL is accepted for objects as well (confirmed with AWS). Container-level ACLs also change here, since they're disabled by default you can't change them unless you change the policy. We need to update existing tests and also add new ones.

evgeniiz321 pushed a commit that referenced this issue Nov 8, 2024
tests: adapt s3 acl tests to new default behavior
beca5b0 
closes #885

Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321 pushed a commit that referenced this issue Nov 8, 2024
tests: adapt s3 acl tests to new default behavior
7656d4f 
closes #885

Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321 pushed a commit that referenced this issue Nov 8, 2024
tests: adapt s3 acl tests to new default behavior
5027067 
closes #885

Signed-off-by: Evgeniy Zayats <[email protected]>
@evgeniiz321 evgeniiz321 mentioned this issue Nov 8, 2024
Merged
evgeniiz321 pushed a commit that referenced this issue Nov 25, 2024
tests: adapt s3 acl tests to new default behavior
fd7a3ae 
closes #885

Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321 pushed a commit that referenced this issue Dec 3, 2024
tests: adapt s3 acl tests to new default behavior
5f22b48 
closes #885

Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321 pushed a commit that referenced this issue Dec 3, 2024
tests: adapt s3 acl tests to new default behavior
e92be4c 
closes #885

Signed-off-by: Evgeniy Zayats <[email protected]>
evgeniiz321 pushed a commit that referenced this issue Dec 3, 2024
tests: adapt s3 acl tests to new default behavior
965d4fc 
closes #885

Signed-off-by: Evgeniy Zayats <[email protected]>
roman-khimov added a commit that referenced this issue Dec 4, 2024
@roman-khimov
tests: adapt s3 acl tests to new default behavior (#894)
a5ff395 
closes #885
@roman-khimov
Copy link
Member Author

https://rest.fs.neo.org/7ZVSQHtioVRiDT2btN9xEmQhczXV9vryCEAHUawfD8Sc/414-1733341109/index.html#suites/88281b571957371013039835abd59035/383ed7d4fa422692/

@roman-khimov roman-khimov reopened this Dec 4, 2024
@roman-khimov
Copy link
Member Author

https://github.com/nspcc-dev/s3-tests as well.

@roman-khimov
Copy link
Member Author

All done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evgeniiz321 evgeniiz321

Labels
feature Completely new functionality I2 Regular impact S4 Routine U2 Seriously planned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: adapt s3 acl tests to new default behavior nspcc-dev/neofs-testcases
2 participants
@evgeniiz321 @roman-khimov