From 0f6425d3a45a4895a3a54d1fd363b6a3382f90db Mon Sep 17 00:00:00 2001 From: Eduardo Almeida Date: Fri, 31 Jan 2025 13:19:00 +0000 Subject: [PATCH] clang-tidy: Raise minimum clang-tidy version to 15 --- build-support/macros-and-definitions.cmake | 4 ++-- doc/contributing/source/coding-style.rst | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/build-support/macros-and-definitions.cmake b/build-support/macros-and-definitions.cmake index c2481cd009..e218d418f1 100644 --- a/build-support/macros-and-definitions.cmake +++ b/build-support/macros-and-definitions.cmake @@ -259,8 +259,8 @@ macro(process_options) if(${NS3_CLANG_TIDY}) find_program( - CLANG_TIDY NAMES clang-tidy clang-tidy-14 clang-tidy-15 clang-tidy-16 - clang-tidy-17 clang-tidy-18 + CLANG_TIDY NAMES clang-tidy clang-tidy-15 clang-tidy-16 clang-tidy-17 + clang-tidy-18 ) if("${CLANG_TIDY}" STREQUAL "CLANG_TIDY-NOTFOUND") message(FATAL_ERROR "Clang-tidy was not found") diff --git a/doc/contributing/source/coding-style.rst b/doc/contributing/source/coding-style.rst index 50753e928d..35f8cf6128 100644 --- a/doc/contributing/source/coding-style.rst +++ b/doc/contributing/source/coding-style.rst @@ -237,9 +237,10 @@ Therefore, it is recommended to use the latest version available. To ensure consistency among developers, |ns3| defines a minimum version of clang-tidy, whose warnings must not be ignored. Therefore, developers should, at least, scan their -code with the minimum version of clang-tidy. +code with the minimum version of clang-tidy. However, more recent versions can be used, +which will produce better warnings. -The minimum version is clang-tidy-14. +The minimum version is clang-tidy-15. Integration with IDEs =====================