-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple terminal popups on Windows #2149
Comments
Hey @cskiwi thanks for the report! |
@MaxKless if I understand the problem correctly, it can be solved once and for all by implementing workspace-wide ESLint rule for Nx Monorepo that fails if |
Everytime I come back to NX, this continues to be an issue. As someone that used to be a supporter of NX, it's very frustrating to be unable to use it outright. Given the severity of this issue, I would've expected an urgent fix, yet here we are months later still dealing with this on windows. Yet another project I've had to pass NX usage on because of this exact cmd prompt popping issue. |
Hey @CodeWithBryan I'm really sorry to hear about this. I tried reproducing on my windows machine and didn't see any popups on neither @cskiwi are you still running into this too on the latest versions? |
I have the same issue, my colleague working on the same project as well. I get cmd consoles popping up from: nx\src\daemon\server\start.js Here my nx report: Node : 20.14.0 nx : 19.2.3
|
Hey thanks everyone for the reports! @cskiwi @nicolasebner @Den-dp you're right it might be time to find a solution to prevent this behaviour altogether. I'll talk about it with the team. |
Should be released later this week :) |
…#26718) ## Current Behavior Using bun as a package manager on windows causes cmd windows to pop up when the project graph is computed. ## Expected Behavior We shouldn't see any windows pop up. ## Related Issue(s) Fixes nrwl/nx-console#2149
@MaxKless speaking of the workspace-wide ESLint rule... Not sure whether it is still relevant to you, but while trying to fix a similar issue in nx-dotnet/nx-dotnet#887, I came up with the following rule nx-dotnet/nx-dotnet@253663f#diff-8f4b5073d52c957e7a4de5f5972eff8864a33308a60905f02cc5f80964e9fde8 |
Still happening with no matter if I run serve, nx g app or just use IntelliJ with the Nx Plugin installed, I constantly see these windows popping up. I had to disable the IntelliJ plugin because those windows stayed open and were frozen all the time |
Yikes I'm sorry to hear that :/ I'll check it out today and see if I can repro it. Can you post your |
guys, please prioritize this as much as it is possible for you. This really reduces productivity by a lot, on every file change in either of main IDEs you get n (3-10) popping out cmd windows (windows platform). Node : 20.17.0 nx (global) : 19.1.2
|
Will do! On it today :) |
any update on the issue? this issue is literally unbearable. |
I've seen these before but I'm really struggling to reproduce the issue on my windows machine. Could you provide a reproduction repo that I can clone and see the issue myself @absurdism2 @mklueh? It must be some specific combination of plugins or the like that's causing this. Usually these popups don't come from Nx Console but from the underlying nx version itself. I'd love to fix this ASAP but it's hard if I don't see the error myself. |
@MaxKless I can try that, but is it possible to get logs on what is opening the cmd with which arguments? Maybe it's easier instead of building a reproducer project, and maybe it's something on my machine specifically. |
You could try setting |
it does pop up whether you have nx-console installed or not (in my case Webstorm), "nx show projects" does trigger, popups, to check i uninstalled it. If i have nx console installed when it refreshes the workspace automatically it does trigger them too, it is not only when you save the file. Work like that is a torment. |
@MaxKless I found one of the problematic places while going through @absurdism2's report: @nx/vite : 19.6.4 |
hi, unfortunately i can not share my repo. What i could add is that i see these terminals being run for e.g. git config, npm evec vite, both as admin and normal user, mainly these are "npm exec vite", run couple of times. I did not have this issue before updating nx to latest version. |
So I couldn't figure out exactly where the issue was in the nx repo but I do have a PR to prevent all these messages: nrwl/nx#28073 Once it's released, let's make sure this is resolved! |
81 files - that's an impressive amount of work 👏 thanks! |
when r u guys planning on releasing it ? |
very soon, you should see a beta or canary release within the day. Proper release this week I think |
Hey! We just cut a release |
Hi. Problems still there, however i see this is happening only on latest webstorm only now. |
your fixes however did move issue forward, previously on every file change (save) I had ton of these terminals, now they only appear when workspace is being refreshed via nx console (webstorm plugin). after uninstalling it all seems fine now, which is inline with what people report here too: #1751 |
That's nice! Are you on the latest nx console version for webstorm? I just released |
Current Behavior
Whenever I make a change in my project after updating to 19.1.0 a couple of terminals popup for a millisecond and then closing again.
Making the whole experience very disturbing because it takes the focus. Making it very hard to work
Expected Behavior
No popups or at least not ones that take the active focus
Steps to Reproduce
Have a project using nx 19.1.0 on windows
Failure Logs / Images / Videos
This is the same as: #1751
Environment
nx report:
I know that angular is still on a prev version of nx because one package hasn't updated to the new angular material formatting giving an error.
but I wouldn't think this would cause that issue
The text was updated successfully, but these errors were encountered: