Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons drawn inline with text #315

Open
skjalgepalg opened this issue Sep 12, 2024 · 0 comments
Open

Icons drawn inline with text #315

skjalgepalg opened this issue Sep 12, 2024 · 0 comments
Assignees

Comments

@skjalgepalg
Copy link
Collaborator

Presently we icons are drawn centred on a 24px * 24px square.

When we need to draw an icon alongside text the icon will hover above the text baseline by however much the gap to the border of the icon grid is. To counter this, developers will need to manually adjust the placement of such icons. Because the icons scale with font-size this manual adjustment must be redone for every different font-size (e.g. headers, quotes etc.). It is also necessary to re-adjust when icons are swapped out due to different gaps to the icon pixel-grid edge.

Thanks to @gesi for raising this issue to my attention.

Do we need to create an inline-version of all icons or is there a solution here that solves inline placement?

Here is a codepen that illustrates the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants