Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRK Super title-right feil padding #267

Open
mengeba opened this issue Jan 31, 2024 · 4 comments
Open

NRK Super title-right feil padding #267

mengeba opened this issue Jan 31, 2024 · 4 comments
Assignees
@skjalgepalg @stefanogden @marve-svenningsen
Labels
enhancement

Comments

@mengeba
Copy link

mengeba commented Jan 31, 2024

NRK Super - logo title right har feil padding på https://static.nrk.no/core-icons/latest/index.html#browse-logos
Riktig i Figma fil

@skjalgepalg
Copy link
Collaborator

Gjorde en kjapp test av NRK Super logo monochrome title right og så at viewbox endret fra viewBox="0 0 55 18" til viewBox="0 0 55 24".
Stemmer oppdateringen?

@mengeba
Copy link
Author

mengeba commented Jan 31, 2024

Det stemmer
image

@skjalgepalg
Copy link
Collaborator

Oppdatert ikon i figma må eksporteres til core-icons/lib/logo/nrk-logo-nrk-super-on-dark.svg og kvernes gjennom svgomg
Endringen konsituerer en breaking change (major release av pakken)

@stefanogden
Copy link

nrk-logo-nrk-super-on-dark.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skjalgepalg skjalgepalg

@stefanogden stefanogden

@marve-svenningsen marve-svenningsen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@skjalgepalg @stefanogden @mengeba @marve-svenningsen