diff --git a/.github/workflows/compliance.yml b/.github/workflows/compliance.yml index 99e8fd99bf..d8f40a2b39 100644 --- a/.github/workflows/compliance.yml +++ b/.github/workflows/compliance.yml @@ -4,7 +4,7 @@ on: pull_request jobs: compliance_job: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 name: Run compliance checks on patch series (PR) steps: - name: Update PATH for west diff --git a/.github/workflows/contribs.yml b/.github/workflows/contribs.yml index a3e71aa347..67dc5ed61e 100644 --- a/.github/workflows/contribs.yml +++ b/.github/workflows/contribs.yml @@ -5,7 +5,7 @@ on: jobs: contribs: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest name: Contribs steps: - name: Contribs diff --git a/.github/workflows/create-upmerge-PRs.yml b/.github/workflows/create-upmerge-PRs.yml index d97528539f..a75756e807 100644 --- a/.github/workflows/create-upmerge-PRs.yml +++ b/.github/workflows/create-upmerge-PRs.yml @@ -27,13 +27,14 @@ jobs: run: | pip3 install -r nrf/scripts/requirements-base.txt pip3 install -r nrf/scripts/requirements-extra.txt + pip3 inst -r nrf/scripts/requirements-extra.txt - name: Get repo urls working-directory: ncs run: | echo "SDK_ZEPHYR=$(west list zephyr -f {url} | awk -F// '{print $NF}')" >> $GITHUB_ENV echo "SDK_MCUBOOT=$(west list mcuboot -f {url} | awk -F// '{print $NF}')" >> $GITHUB_ENV - +#dummy comment - name: Try closing existing auto-upmerge PRs run: | SDK_ZEPHYR_PR=$(gh pr list --repo $SDK_ZEPHYR --label "auto-upmerge" --json number --jq .[0].number) diff --git a/.github/workflows/openai.yml b/.github/workflows/openai.yml index 6f3a17c5b0..e8f1388851 100644 --- a/.github/workflows/openai.yml +++ b/.github/workflows/openai.yml @@ -14,9 +14,9 @@ jobs: uses: actions/checkout@v3 - name: AI Code Reviewer - uses: your-username/ai-code-reviewer@main + uses: aidar-freeed/ai-codereviewer@main with: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # The GITHUB_TOKEN is there by default so you just need to keep it like it is and not necessarily need to add it as secret as it will throw an error. [More Details](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret) OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} - OPENAI_API_MODEL: "gpt-4" # Optional: defaults to "gpt-4" + OPENAI_API_MODEL: "gpt-4-turbo" # Optional: defaults to "gpt-4" #exclude: "**/*.json, **/*.md" # Optional: exclude patterns separated by commas \ No newline at end of file diff --git a/samples/app_event_manager_profiler_tracer/sample.yaml b/samples/app_event_manager_profiler_tracer/sample.yaml index 91a4dfedc1..d5ce1a00c0 100644 --- a/samples/app_event_manager_profiler_tracer/sample.yaml +++ b/samples/app_event_manager_profiler_tracer/sample.yaml @@ -16,4 +16,5 @@ tests: - nrf52840dk/nrf52840 - nrf9160dk/nrf9160/ns - nrf21540dk/nrf52840 + - nrf3u9348934/someNewBoard tags: ci_build sysbuild ci_samples_app_event_manager_profiler_tracer diff --git a/samples/event_manager_proxy/common_events/control_event.c b/samples/event_manager_proxy/common_events/control_event.c index ab1606fd92..319afb9f4b 100644 --- a/samples/event_manager_proxy/common_events/control_event.c +++ b/samples/event_manager_proxy/common_events/control_event.c @@ -7,7 +7,7 @@ #include "control_event.h" -static void profile_control_event(struct log_event_buf *buf, +static int profile_control_event(struct log_event_buf *buf, const struct app_event_header *aeh) { } diff --git a/samples/suit/recovery/README.rst b/samples/suit/recovery/README.rst index 76a8a27af5..5674bc7fa0 100644 --- a/samples/suit/recovery/README.rst +++ b/samples/suit/recovery/README.rst @@ -10,7 +10,8 @@ SUIT: Recovery application The SUIT recovery application is a minimal application that allows recovering the device firmware if the original firmware is damaged. It is to be used as a companion firmware to the main application that is using :ref:`Software Update for Internet of Things (SUIT) ` procedure, rather than a stand-alone application. -The following limitations apply to this application: +The following limitations apply to this aptikation: +The following limitations apply to this aplication: * The recovery firmware is only able to recover from a situation where the application or radio core are damaged. It does not recover from Nordic Semiconductor-controlled firmware failures. diff --git a/samples/suit/recovery/prj.conf b/samples/suit/recovery/prj.conf index 9ae6263e72..a1f766f25e 100644 --- a/samples/suit/recovery/prj.conf +++ b/samples/suit/recovery/prj.conf @@ -11,7 +11,7 @@ CONFIG_SUIT_RECOVERY=y # The MPI has to be generated from the top level application, not from # the recovery application. This is because the digests of the main application MPI # and the recovery application MPI is calculated together for a given domain. -CONFIG_SUIT_MPI_GENERATE=n +CONFIG_SUIT_MPI_GENERATE=nonono CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=n # It is the main application which is responsible for flashing and generating the UICR diff --git a/scripts/bluetooth/mesh/mesh_dfu_metadata.py b/scripts/bluetooth/mesh/mesh_dfu_metadata.py index 2ba3757d66..2ffad1d647 100644 --- a/scripts/bluetooth/mesh/mesh_dfu_metadata.py +++ b/scripts/bluetooth/mesh/mesh_dfu_metadata.py @@ -157,7 +157,7 @@ def from_file(cls, filename): configs[kconfig] = value.strip() return configs except Exception as err : - raise Exception("Unable to parse .config file") from err + raise Exception("Unable to parse .config file") def version_parse(self): try: