Skip to content

Commit 829e3ed

Browse files
joerchande-nordic
authored andcommitted
[nrf fromlist] psa_crypto: Fix psa_key_derivation_output_key ECC without builtin keys
Fix psa_key_derivation_output_key not being able to derive ECC keys without MBEDTLS_BUILTIN ECC key types enabled. The PSA crypto drivers can generate these keys without requiring the builtin key types. Upstream PR: Mbed-TLS/mbedtls#7192 Signed-off-by: Joakim Andersson <[email protected]> (cherry picked from commit de1b3f5) (cherry picked from commit 5881d82)
1 parent a58396e commit 829e3ed

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

library/psa_crypto.c

+12-12
Original file line numberDiff line numberDiff line change
@@ -332,8 +332,8 @@ psa_status_t mbedtls_to_psa_error( int ret )
332332
/* Key management */
333333
/****************************************************************/
334334

335-
#if defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_ECC_KEY_PAIR) || \
336-
defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_ECC_PUBLIC_KEY) || \
335+
#if defined(PSA_WANT_KEY_TYPE_ECC_KEY_PAIR) || \
336+
defined(PSA_WANT_KEY_TYPE_ECC_PUBLIC_KEY) || \
337337
defined(MBEDTLS_PSA_BUILTIN_ALG_ECDSA) || \
338338
defined(MBEDTLS_PSA_BUILTIN_ALG_DETERMINISTIC_ECDSA) || \
339339
defined(MBEDTLS_PSA_BUILTIN_ALG_ECDH)
@@ -431,8 +431,8 @@ mbedtls_ecp_group_id mbedtls_ecc_group_of_psa( psa_ecc_family_t curve,
431431
(void) bits_is_sloppy;
432432
return( MBEDTLS_ECP_DP_NONE );
433433
}
434-
#endif /* defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_ECC_KEY_PAIR) ||
435-
defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_ECC_PUBLIC_KEY) ||
434+
#endif /* defined(PSA_WANT_KEY_TYPE_ECC_KEY_PAIR) ||
435+
defined(PSA_WANT_KEY_TYPE_ECC_PUBLIC_KEY) ||
436436
defined(MBEDTLS_PSA_BUILTIN_ALG_ECDSA) ||
437437
defined(MBEDTLS_PSA_BUILTIN_ALG_DETERMINISTIC_ECDSA) ||
438438
defined(MBEDTLS_PSA_BUILTIN_ALG_ECDH) */
@@ -4800,8 +4800,8 @@ static void psa_des_set_key_parity( uint8_t *data, size_t data_size )
48004800
* Note: Function allocates memory for *data buffer, so given *data should be
48014801
* always NULL.
48024802
*/
4803-
#if defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_ECC_KEY_PAIR) || \
4804-
defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_ECC_PUBLIC_KEY) || \
4803+
#if defined(PSA_WANT_KEY_TYPE_ECC_KEY_PAIR) || \
4804+
defined(PSA_WANT_KEY_TYPE_ECC_PUBLIC_KEY) || \
48054805
defined(MBEDTLS_PSA_BUILTIN_ALG_ECDSA) || \
48064806
defined(MBEDTLS_PSA_BUILTIN_ALG_DETERMINISTIC_ECDSA) || \
48074807
defined(MBEDTLS_PSA_BUILTIN_ALG_ECDH)
@@ -4963,8 +4963,8 @@ static psa_status_t psa_generate_derived_ecc_key_montgomery_helper(
49634963

49644964
return status;
49654965
}
4966-
#endif /* defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_ECC_KEY_PAIR) ||
4967-
defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_ECC_PUBLIC_KEY) ||
4966+
#endif /* defined(PSA_WANT_KEY_TYPE_ECC_KEY_PAIR) ||
4967+
defined(PSA_WANT_KEY_TYPE_ECC_PUBLIC_KEY) ||
49684968
defined(MBEDTLS_PSA_BUILTIN_ALG_ECDSA) ||
49694969
defined(MBEDTLS_PSA_BUILTIN_ALG_DETERMINISTIC_ECDSA) ||
49704970
defined(MBEDTLS_PSA_BUILTIN_ALG_ECDH) */
@@ -4982,8 +4982,8 @@ static psa_status_t psa_generate_derived_key_internal(
49824982
if( PSA_KEY_TYPE_IS_PUBLIC_KEY( slot->attr.type ) )
49834983
return( PSA_ERROR_INVALID_ARGUMENT );
49844984

4985-
#if defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_ECC_KEY_PAIR) || \
4986-
defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_ECC_PUBLIC_KEY) || \
4985+
#if defined(PSA_WANT_KEY_TYPE_ECC_KEY_PAIR) || \
4986+
defined(PSA_WANT_KEY_TYPE_ECC_PUBLIC_KEY) || \
49874987
defined(MBEDTLS_PSA_BUILTIN_ALG_ECDSA) || \
49884988
defined(MBEDTLS_PSA_BUILTIN_ALG_DETERMINISTIC_ECDSA) || \
49894989
defined(MBEDTLS_PSA_BUILTIN_ALG_ECDH)
@@ -5005,8 +5005,8 @@ static psa_status_t psa_generate_derived_key_internal(
50055005
goto exit;
50065006
}
50075007
} else
5008-
#endif /* defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_ECC_KEY_PAIR) ||
5009-
defined(MBEDTLS_PSA_BUILTIN_KEY_TYPE_ECC_PUBLIC_KEY) ||
5008+
#endif /* defined(PSA_WANT_KEY_TYPE_ECC_KEY_PAIR) ||
5009+
defined(PSA_WANT_KEY_TYPE_ECC_PUBLIC_KEY) ||
50105010
defined(MBEDTLS_PSA_BUILTIN_ALG_ECDSA) ||
50115011
defined(MBEDTLS_PSA_BUILTIN_ALG_DETERMINISTIC_ECDSA) ||
50125012
defined(MBEDTLS_PSA_BUILTIN_ALG_ECDH) */

0 commit comments

Comments
 (0)