Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphRequest property names break VB6 #1144

Open
nozzlegear opened this issue Jan 23, 2025 · 1 comment
Open

GraphRequest property names break VB6 #1144

nozzlegear opened this issue Jan 23, 2025 · 1 comment
Labels

Comments

@nozzlegear
Copy link
Owner

From #1051:

I'm sure I'm the last visual basic programmer on the planet, but now this class is crashing as VB can't handle there being a query property and a Query property.

@nozzlegear nozzlegear added the bug label Jan 23, 2025
@nozzlegear
Copy link
Owner Author

@dg107 Can you confirm, is it just the GraphRequest class that breaks in Visual Basic because of the duplicate property names? Would you be open to adding a compiler constant to your build that disables the duplicate properties in that class?

I'm thinking about doing something like this, temporarily:

public class GraphRequest
{
    #if !SHOPIFYSHARP_VB_MODE
    [Obsolete("This property is deprecated, use " + nameof(Query) + " instead.")]
    public string query { get; set; }
    #endif

    public string Query { get; set; }
}

Then you could set SHOPIFYSHARP_VB_MODE=true inside your vbproj file:

<PropertyGroup>
    <DefineConstants>SHOPIFYSHARP_VB_MODE=True</DefineConstants>
</PropertyGroup>

Does that sound feasible to you? It'd only be a temporary solution, I plan on removing the deprecated properties in about 90 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant