Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of active-support #56

Open
clgiovannelli opened this issue Nov 9, 2023 · 10 comments
Open

Bump version of active-support #56

clgiovannelli opened this issue Nov 9, 2023 · 10 comments

Comments

@clgiovannelli
Copy link

Hi all,
do you think is possible to use activesupport > 6.1.7.2 instead of activesupport = 6.1.7.2?

Thank you in advance

@clgiovannelli
Copy link
Author

Any update?

@unicodeveloper
Copy link
Contributor

Any particular reason for this request? @clgiovannelli

@clgiovannelli
Copy link
Author

Thank you for getting back to me, actually I can't install the gem with the latest version of Rails.

@clgiovannelli
Copy link
Author

Hi there, I'm considering integrating NOVU into our production environment. I was wondering if you have plans to continue maintaining the Ruby gem? Your guidance on this would be greatly appreciated. Thank you!

@Eazybright
Copy link
Contributor

Any particular reason for this request? @clgiovannelli

@unicodeveloper The sdk is pegged to version 6.1.7.2 for the activesupport dependency, that was the configuration at the beginning. It would be nice to allow the sdk accept higher version of activesupport dependency for forward compatibility sake.

@jainpawan21
Copy link
Member

Any particular reason for this request? @clgiovannelli

@unicodeveloper The sdk is pegged to version 6.1.7.2 for the activesupport dependency, that was the configuration at the beginning. It would be nice to allow the sdk accept higher version of activesupport dependency for forward compatibility sake.

@Eazybright would you like to work on this?

@unicodeveloper
Copy link
Contributor

I have tagged a new release. v1.1.0. Please update your gem @clgiovannelli

@clgiovannelli
Copy link
Author

Hi @unicodeveloper,

After updating the gem, it appears that it can't find exponential-backoff and uuid. In fact, these dependencies were not defined in the gemspec. I resolved the issue by manually adding the gems to the bundler. However, it would be greatly appreciated if these dependencies could be included in the gemspec.

Thank you in advance.

@Eazybright
Copy link
Contributor

@clgiovannelli thanks for pointing this out. A PR has been raised to fix it #65

@clgiovannelli
Copy link
Author

@clgiovannelli thanks for pointing this out. A PR has been raised to fix it #65

It's working, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants