Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container with rounded corners and title has bad position #377

Open
merwok opened this issue Nov 5, 2019 · 0 comments
Open

Container with rounded corners and title has bad position #377

merwok opened this issue Nov 5, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@merwok
Copy link

merwok commented Nov 5, 2019

Describe the bug
On firefox, container rounded with title has an unwanted border.

To Reproduce

    <div class="nes-container is-rounded with-title">
      <h1 class="title">Not found!</h1>
      <p>Sorry, the requested page does not exist.</p>
    </div>

Observed issue with and without is-centered.

Expected behavior
Get a container with rounded corners + title displayed interrupting the top border.

Screenshots

container-rounded-title

Testing on demo site (by adding a class using DOM inspector) does not show the problem:
demo-container

Environment:

  • OS: Debian testing
  • Browser: Firefox 68.2.0esr

Suggestion(s) for fixing this issue
I haven’t redefined text size for root element, so with browser defaults the margin-top of -1.5rem is not enough to end up at the right place to cover the border. -1.6rem does the trick.

I am already redefining some style from nes.css (to avoid white background), so I may change this too to have -2rem which looks great to me 😎

@guastallaigor guastallaigor added bug Something isn't working help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants