Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no other commands show than the command "netease music: start" #67

Closed
sunnysunny3145 opened this issue Oct 2, 2019 · 4 comments
Closed

Comments

@sunnysunny3145
Copy link

So appreciate this extension.

I successful open VS code and run the command "netease music: start". However, no other commands show when I'm trying to search netease related commands after pressing F1. I entered the page "Please preserve this webview tab" already. It is my first time to use it. Any recommands?

My OS: windows 10
VS code version: 1.38.1
electron version: 4.2.10
already replace the ffmpeg.dll manually.

@nondanee
Copy link
Owner

nondanee commented Oct 5, 2019

I test with the same environment as yours but can not reproduce the error.

Be sure that your VS Code can access network. (No offline mode at present #62)

In startup phase, the extension will connect to NeteaseMusic server for checking the account login status and daily sign status, also fetching user's favorite songs (in component.refresh method)

runtime.event.once('ready', () =>
Promise.all([api, controller].map(component => component.refresh()))
.then(() => controller.restore())
.then(() => runtime.stateManager.set('on', true))
)

@sunnysunny3145
Copy link
Author

I test with the same environment as yours but can not reproduce the error.

Be sure that your VS Code can access network. (No offline mode at present #62)

In startup phase, the extension will connect to NeteaseMusic server for checking the account login status and daily sign status, also fetching user's favorite songs (in component.refresh method)

runtime.event.once('ready', () =>
Promise.all([api, controller].map(component => component.refresh()))
.then(() => controller.restore())
.then(() => runtime.stateManager.set('on', true))
)

Thanks a lot for your help. I tried it in another PC which works. I guess it is the proxy configuration problem. The failed one need to go through a http proxy to access the internet. The VS code follow my browser's proxy configuration so that I can download apps without any problem. It looks like the vsc-netease-music didn't go through proxy correct. Is there any way to configure this extension on the proxy with user name and passcode? So appreciates. XD

@nondanee
Copy link
Owner

nondanee commented Oct 9, 2019

I checked the issue microsoft/vscode#12588 (comment)

The official says they have already patched on http and https modules for extension.

Just authentication does not work

I test and the requests from my extension really bypass the http.proxy set in setting.json.
So I will not do extra work but wait the official support for proxy authentication.

Thank you for your understanding.

@sunnysunny3145
Copy link
Author

I checked the issue microsoft/vscode#12588 (comment)

The official says they have already patched on http and https modules for extension.

Just authentication does not work

I test and the requests from my extension really bypass the http.proxy set in setting.json.
So I will not do extra work but wait the official support for proxy authentication.

Thank you for your understanding.

So glad we found the reason. XD Appreciate your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants