Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: Add containerRole parameter #7705

Closed
3 of 4 tasks
michaelbourne opened this issue Aug 27, 2024 · 1 comment
Closed
3 of 4 tasks

A11y: Add containerRole parameter #7705

michaelbourne opened this issue Aug 27, 2024 · 1 comment

Comments

@michaelbourne
Copy link
Contributor

Clear and concise description of the problem

The Accessibility module currently allows for a aria-roledescription attribute on the slider container via the containerRoleDescriptionMessage option, but there is no support for setting a role to the same container.

As per https://www.w3.org/TR/wai-aria-1.1/#aria-roledescription, this is a slight violation of best practices, and my a11y auditors have flagged it as an issue to be fixed.

Suggested solution

Add a containerRole parameter to the Accessibility module so we can set the proper role (region) when setting the containerRoleDescriptionMessage option.

Alternative

No response

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Would you like to open a PR for this feature?

  • I'm willing to open a PR
@nolimits4web
Copy link
Owner

What is the issue? What does it do? What is it for? What does it fix? Why you can't just add aria-role with "hands" to HTML element?

Your issue is closed because it is not filled correctly. Before you open an issue please review the contributing guideline.

Please fill the issue template correctly and:

  • Clearly describe the issue including steps to reproduce when it is a bug.
  • Make sure you fill in the earliest version that you know has the issue.
  • Provide live link or JSFiddle/Codepen or website with isssue

It will save a lot of time for other contributors to check your issue and fix it.

Repository owner locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants