chore: update to use noir bignum 0.4.2 #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signorecello
requested review from
zac-williamson,
iAmMichaelConnor and
jtriley-eth
TomAFrench
requested changes
Nov 27, 2024
Comment on lines
-539
to
-558
| #[make_test(quote{BN254}, quote{BigNum<3, 254, BN254_Fq_Params>}, quote{BN254Scalar})] | ||
| pub struct BN254GenTests {} | ||
| #[make_test(quote{Vesta}, quote{VestaFr}, quote{VestaScalar})] | ||
| pub struct VestaGenTests {} | ||
| #[make_test(quote{Pallas}, quote{PallasFr}, quote{PallasScalar})] | ||
| pub struct PallasGenTests {} | ||
| #[make_test(quote{BLS12_377}, quote{BLS12_377Fr}, quote{BLS12_377Scalar})] | ||
| pub struct BLS377GenTests {} | ||
| #[make_test(quote{BLS12_381}, quote{BLS12_381Fr}, quote{BLS12_381Scalar})] | ||
| pub struct BLS381GenTests {} | ||
| #[make_test(quote{Secp256k1}, quote{Secp256k1Fr}, quote{Secp256k1Scalar})] | ||
| pub struct Secp256k1GenTests {} | ||
| #[make_test(quote{Secp256r1}, quote{Secp256r1Fr}, quote{Secp256r1Scalar})] | ||
| pub struct Secp256r1GenTests {} | ||
| #[make_test(quote{Secp384r1}, quote{Secp384r1Fr}, quote{Secp384r1Scalar})] | ||
| pub struct Secp384r1GenTests {} | ||
| #[make_test(quote{MNT4_753}, quote{MNT4_753Fr}, quote{MNT4_753Scalar})] | ||
| pub struct MNT4GenTests {} | ||
| #[make_test(quote{MNT6_753}, quote{MNT6_753Fr}, quote{MNT6_753Scalar})] | ||
| pub struct MNT6GenTests {} |
There was a problem hiding this comment.
This is just deleting all the tests. Instead can you change them to work on modules such as in the bignum library?
There was a problem hiding this comment.
Oh sorry I deleted the tests by mistake, should’ve double checked the PR. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling was complaining about missing types
closes #14 as this was a bignum problem