Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inliner removes some functions used by the debugger #6955

Open
jfecher opened this issue Jan 6, 2025 · 0 comments
Open

Inliner removes some functions used by the debugger #6955

jfecher opened this issue Jan 6, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@jfecher
Copy link
Contributor

jfecher commented Jan 6, 2025

Aim

Discovered in #6894, the SSA inlining pass can remove functions used in the debugger.

Expected Behavior

The inlining pass shouldn't remove any functions that are still in use

Bug

In the higher_order_functions test, inlining will remove functions still referenced by the debugger, although the remaining SSA passes seem unbothered by this.

To Reproduce

  1. Comment out the normalize_ids() pass in compiler/noirc_evaluator/src/ssa.rs line 493
  2. $ cd test_programs/execution_success/higher_order_functions
  3. $ cargo run debug --force-brillig --show-ssa > ssa
  4. Inspect the resulting SSA to find f13 is still used after the first inlining pass but there is no longer a corresponding fn lambda f13 in the program.

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the bug Something isn't working label Jan 6, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant